fix: Count line break characters as ASCII #8376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, shaka.util.StringUtils.fromBytesAutoDetect assumed any character between ' ' and '~' was ASCII. This worked for many cases, but it meant that the method would be unable to determine the encoding of a buffer if there was a newline character near the start. This could be a problem for parsing, for example, JSON. Closes shaka-project#8336
Collaborator
|
Incremental code coverage: 100.00% |
joeyparrish
approved these changes
Apr 1, 2025
avelad
pushed a commit
that referenced
this pull request
Apr 4, 2025
Previously, shaka.util.StringUtils.fromBytesAutoDetect assumed any character between ' ' and '~' was ASCII. This worked for many cases, but it meant that the method would be unable to determine the encoding of a buffer if there was a newline character near the start. This could be a problem for parsing, for example, JSON. Closes #8336
avelad
pushed a commit
that referenced
this pull request
Apr 4, 2025
Previously, shaka.util.StringUtils.fromBytesAutoDetect assumed any character between ' ' and '~' was ASCII. This worked for many cases, but it meant that the method would be unable to determine the encoding of a buffer if there was a newline character near the start. This could be a problem for parsing, for example, JSON. Closes #8336
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, shaka.util.StringUtils.fromBytesAutoDetect assumed any character between ' ' and '~' was ASCII.
This worked for many cases, but it meant that the method would be unable to determine the encoding of a buffer if there was a newline character near the start.
This could be a problem for parsing, for example, JSON.
Closes #8336