Skip to content

Conversation

@srikieonline
Copy link
Contributor

Some platforms may have some issues around load api. Provide apps to configure using load API or setting src to mediasource. Defaults to using load API.

Some platforms may have some issues around load api.
Provide apps to configure using load API or setting
src to mediasource. Defaults to using load API.
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Apr 2, 2025
@avelad avelad added this to the v4.15 milestone Apr 2, 2025
@srikieonline
Copy link
Contributor Author

'has an entry for every config option' tests are failing. From tracing the code, it looks like the config is created from default in player_configuration.js in createDefault API. And I've already added useLoad config in there. Any clue where else I should be looking at?

@avelad
Copy link
Member

avelad commented Apr 2, 2025

'has an entry for every config option' tests are failing. From tracing the code, it looks like the config is created from default in player_configuration.js in createDefault API. And I've already added useLoad config in there. Any clue where else I should be looking at?

You need add the new config here: https://github.com/shaka-project/shaka-player/blob/main/demo/config.js#L681

@shaka-bot
Copy link
Collaborator

shaka-bot commented Apr 2, 2025

Incremental code coverage: 80.00%

Srikanth Peddibhotla and others added 2 commits April 2, 2025 14:53
@srikieonline
Copy link
Contributor Author

Looks like the test failures are not related to this change. Known issue?

@tykus160
Copy link
Member

tykus160 commented Apr 3, 2025

@srikieonline Firefox failing test around cross boundary is a known issue.

@tykus160 tykus160 changed the title feat: provide option to use load api feat: provide option to disable usage of source elements in MSE Apr 4, 2025
@avelad avelad merged commit b0cd08b into shaka-project:main Apr 4, 2025
17 checks passed
@matvp91
Copy link
Member

matvp91 commented Apr 5, 2025

@srikieonline, for reference, which devices are we talking about? There's device detection that adds specific defaults to the config for a set of devices.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 3, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants