-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: provide option to disable usage of source elements in MSE #8386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some platforms may have some issues around load api. Provide apps to configure using load API or setting src to mediasource. Defaults to using load API.
|
'has an entry for every config option' tests are failing. From tracing the code, it looks like the config is created from default in player_configuration.js in createDefault API. And I've already added useLoad config in there. Any clue where else I should be looking at? |
You need add the new config here: https://github.com/shaka-project/shaka-player/blob/main/demo/config.js#L681 |
|
Incremental code coverage: 80.00% |
added config in demo app.
|
Looks like the test failures are not related to this change. Known issue? |
|
@srikieonline Firefox failing test around cross boundary is a known issue. |
|
@srikieonline, for reference, which devices are we talking about? There's device detection that adds specific defaults to the config for a set of devices. |
Some platforms may have some issues around load api. Provide apps to configure using load API or setting src to mediasource. Defaults to using load API.