feat: Use Date for playback start time #8415
Merged
+140
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
reviewed
Apr 8, 2025
Collaborator
|
Incremental code coverage: 58.65% |
avelad
approved these changes
Apr 8, 2025
gkatsev
approved these changes
Apr 8, 2025
Contributor
gkatsev
left a comment
There was a problem hiding this comment.
If Date is used on VOD, nothing will happen.
Why limit this to live only? VOD can have PDT data as well. That said, it's less useful for VOD. Either way, not a blocker, as it could be added in later too if we wanted.
LGTM!
Member
Author
I updated description. There is no direct limitation for VOD, actually it relies of existence of PDT. |
tykus160
added a commit
to sky-hugolima/shaka-player-contrib
that referenced
this pull request
May 20, 2025
Cherrypick from shaka-project#8415 This PR introduces ability to pass Date object instead of number to `shaka.Player#load()` call. Date, together with PDT is used to calculate relative start time. If stream does not have PDT, nothing will happen. Additionally, for src= playback, we set current time on `canplay` event now instead of `loadeddata`. It seems that Safari goes to live edge on it's own if we set time too soon. Co-authored-by: Wojciech Tyczyński <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8402
This PR introduces ability to pass Date object instead of number to
shaka.Player#load()call. Date, together with PDT is used to calculate relative start time.If stream does not have PDT, nothing will happen.
Additionally, for src= playback, we set current time on
canplayevent now instead ofloadeddata. It seems that Safari goes to live edge on it's own if we set time too soon.