feat: Handle audio focus events #8427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Incremental code coverage: 74.07% |
absidue
reviewed
Apr 9, 2025
Contributor
absidue
left a comment
There was a problem hiding this comment.
As these seem to be non-standard events, it might be worth adding a code comment that explains on which platforms those events are available, so that people that look at the code in the future know why it is there, as the PR description currently only says "some platforms".
tykus160
reviewed
Apr 9, 2025
avelad
approved these changes
Apr 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some platforms custom audio focus events are emitted. This needs to be handled to avoid the stall detection.