Skip to content

Conversation

@avelad
Copy link
Member

@avelad avelad commented May 5, 2025

This allows the segmentIndex to be created if it is not already created and also allows operation with CastProxy.

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels May 5, 2025
@avelad avelad added this to the v4.15 milestone May 5, 2025
This allows the segmentIndex to be created if it is not already created and also allows operation with CastProxy.
@avelad avelad force-pushed the getChaptersAsync branch from 079be37 to 04e38cd Compare May 5, 2025 09:25
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 91.67%

Copy link
Contributor

@TAhub TAhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're deprecating this in v5, it should probably be mentioned in the Player API Changes in the upgrade guide.

@avelad avelad requested a review from TAhub May 5, 2025 19:34
@avelad
Copy link
Member Author

avelad commented May 5, 2025

If we're deprecating this in v5, it should probably be mentioned in the Player API Changes in the upgrade guide.

Done!

@avelad avelad merged commit ba56bae into shaka-project:main May 6, 2025
36 of 46 checks passed
@avelad avelad deleted the getChaptersAsync branch May 6, 2025 07:58
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 5, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants