[core] Load the projects list without activating the projectile-mode

[sunlin7]

Use the function (projectile-known-projects) to replace the function (projectile-relevant-known-projects) for correctly getting the project list.

This patch will:

1. don't active the projectile-mode in spacemacs-buffer
2. just load the projects by projectile function projectile-known-projects which was introduced in the commit bbatsov/projectile@373fca7.

The projectile is part of +distributions/spacemacs/:

spacemacs/layers/+distributions/spacemacs/layers.el

Line 43 in cc9b605

spacemacs-project

And it's activated in the function spacemacs-project/init-projectile.

The projectile-mode is NOT part of +distributions/spacemacs-base/:

spacemacs/layers/+distributions/spacemacs-base/layers.el

Line 28 in cc9b605

(configuration-layer/declare-layers '(spacemacs-defaults))

But it was activated in the (spacemacs-buffer//insert-projects) even user selected the spacemacs-base as dotspacemacs-distribution.

[bcc32]

I'm not currently at my personal computer to test this, but:

If the user has selected spacemacs-base as the distribution, without enabling the spacemacs-project layer... is projectile even installed? In that case, won't the spacemacs-buffer trigger an error?

If the above is correct, I feel like the better solution would be to skip the calls to projectile-known-projects rather than attempting to autoload it.

[sunlin7]

@bcc32 Thanks for the comment. The projectile will be installed as dependency of helm-porjectile and treemacs-projectile, which are from the default value of dotspacemacs-configuration-layers included the helm and treemacs.

If remove the helm and treemacs from layers, the spacemacs-base will not going to install the projectile.

Keep project list on Spacemacs startup buffer will provide consistent user experience.

[bcc32]

I think if a user has gone out of their way to exclude the spacemacs-project layer, they are saying they don't want projectile-mode at all. In that case, installing/loading it anyway seems unhelpful.

[bcc32]

And it would be nice to take this opportunity to support Spacemacs starting up properly without projectile installed at all (e.g., if the user wants to exclude it in their dotfile)

[sunlin7]

@bcc32
The key point is, original function (projectile-relevant-known-projects) has two issue here:

1. will remove the project for current directory from the project list
2. require the projectile-mode to be enabled on the spacemacs-buffer.

This PR will use the function (projectile-known-projects) which just load the project list without side effects.

[sunlin7]

Got your points, mark this PR as draft first, will enhance it towards the comments.

[sunlin7]

@bcc32
It works without projectile package after setting the dotspacemacs-distribution 'spacemacs-base and dotspacemacs-configuration-layers '(). I confirmed on my local.

Before calling projectile function, it will detect projectile feature by (fboundp 'projectile-mode) on these lines:

spacemacs/core/core-spacemacs-buffer.el

Lines 1450 to 1453 in 7d0ddf0

	((eq el 'recents) (spacemacs-buffer//insert-recent-files list-size))
	((and (eq el 'recents-by-project)
	(fboundp 'projectile-mode))
	(spacemacs-buffer//insert-recent-files-by-project list-size))

spacemacs/core/core-spacemacs-buffer.el

Lines 1456 to 1459 in 7d0ddf0

	((eq el 'bookmarks) (spacemacs-buffer//insert-bookmarks list-size))
	((and (eq el 'projects)
	(fboundp 'projectile-mode))
	(spacemacs-buffer//insert-projects list-size)))))))

So the changes works for projectile exists or projectile not exists cases.

[bcc32]

Got it, thank you for explaning.

[sunlin7]

Thank you!