Page MenuHomePhabricator
Create Task
Maniphest T100439

Special:RecentChanges does not list tags, filter broken
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Searching visualeditor tag in RecentChanges of enwiki does not list anything after May 23

https://en.wikipedia.org/w/index.php?namespace=&tagfilter=visualeditor&title=Special%3ARecentChanges

Same is noted with other tags in other wikis too.

See also:
T100248: Programmatically applied change tags don't show on Recent Changes

Details

SubjectRepoBranchLines +/-
Defer RC tag addition in the publish APImediawiki/extensions/ContentTranslationmaster+14 -10
Use more appropriate RecentChange_save hook for taggingmediawiki/extensions/VisualEditorwmf/1.26wmf7+13 -21
Use more appropriate RecentChange_save hook for taggingmediawiki/extensions/VisualEditorwmf/1.26wmf8+13 -21
Use more appropriate RecentChange_save hook for taggingmediawiki/extensions/VisualEditorwmf/1.26wmf6+13 -21
Use more appropriate RecentChange_save hook for taggingmediawiki/extensions/VisualEditormaster+13 -21
Customize query in gerrit

Related Objects

Event Timeline

KartikMistry created this task.May 26 2015, 4:58 PM
KartikMistry raised the priority of this task from to Needs Triage.
KartikMistry updated the task description. (Show Details)
KartikMistry added projects: ContentTranslation, ContentTranslation-Release5.
KartikMistry subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2015, 4:58 PM
santhosh triaged this task as High priority.May 26 2015, 5:02 PM
santhosh subscribed.

It seems cawiki(and probably others too) missing tags
https://ca.wikipedia.org/w/index.php?title=Especial:Canvis_recents&tagfilter=contenttranslation

santhosh renamed this task from contenttranslation tag doesn't apply to Special:RecentChanges does not list tags, filter broken.May 27 2015, 3:20 AM
santhosh raised the priority of this task from High to Needs Triage.
santhosh updated the task description. (Show Details)
santhosh edited projects, added MediaWiki-Change-tagging, MediaWiki-Recent-changes; removed ContentTranslation-Release5, ContentTranslation.
santhosh set Security to None.
Glaisher subscribed.May 27 2015, 4:51 AM
ssastry subscribed.May 27 2015, 5:44 PM

https://fr.wikipedia.org/w/index.php?title=Sp%C3%A9cial:Modifications_r%C3%A9centes&namespace=&tagfilter=visualeditor shows that this is true for frwiki as well.

This also affects Parsoid's ability to test post-deploy and we might have to pause deploys till we fix this.

ssastry added a subscriber: Jdforrester-WMF.May 27 2015, 5:45 PM
ssastry triaged this task as Unbreak Now! priority.May 27 2015, 5:48 PM
cscott subscribed.May 27 2015, 5:50 PM
• Rdicerb subscribed.May 27 2015, 5:55 PM
Ciencia_Al_Poder added subscribers: Ciencia_Al_Poder, aaron.May 27 2015, 5:56 PM

cc'ing aaron, since it may be related to commit rMWda79b19b8848 which was merged to wmf/1.26wmf7 on May 22

Ciencia_Al_Poder added a comment.May 27 2015, 5:59 PM
In T100439#1315080, @Ciencia_Al_Poder wrote:

cc'ing aaron, since it may be related to commit rMWda79b19b8848 which was merged to wmf/1.26wmf7 on May 22

No, sorry. It was probably related to the regression mentioned in rMW549bfc0ee5c83224c80ddad4970548092b4ffdbf

Ciencia_Al_Poder updated the task description. (Show Details)May 27 2015, 6:05 PM
cscott mentioned this in T100248: Programmatically applied change tags don't show on Recent Changes.May 27 2015, 6:13 PM
gerritbot subscribed.May 27 2015, 6:36 PM

Change 214101 had a related patch set uploaded (by Aaron Schulz):
Use more appropriate RecentChange_save hook for tagging

https://gerrit.wikimedia.org/r/214101

gerritbot added a project: Patch-For-Review.May 27 2015, 6:36 PM
Krenair subscribed.May 27 2015, 8:50 PM
gerritbot added a comment.May 28 2015, 5:30 PM

Change 214385 had a related patch set uploaded (by Jforrester):
Use more appropriate RecentChange_save hook for tagging

https://gerrit.wikimedia.org/r/214385

gerritbot added a comment.May 28 2015, 5:30 PM

Change 214386 had a related patch set uploaded (by Jforrester):
Use more appropriate RecentChange_save hook for tagging

https://gerrit.wikimedia.org/r/214386

gerritbot added a comment.May 28 2015, 5:31 PM

Change 214101 merged by jenkins-bot:
Use more appropriate RecentChange_save hook for tagging

https://gerrit.wikimedia.org/r/214101

aaron mentioned this in rEVEDa948624ddaf1: Use more appropriate RecentChange_save hook for tagging.May 28 2015, 5:31 PM
gerritbot added a comment.May 28 2015, 5:32 PM

Change 214390 had a related patch set uploaded (by Jforrester):
Use more appropriate RecentChange_save hook for tagging

https://gerrit.wikimedia.org/r/214390

• gpaumier added a project: User-notice.May 28 2015, 5:35 PM
• gpaumier moved this task from To Triage to Announce in next Tech/News on the User-notice board.
• gpaumier mentioned this in T94767: Perform a weekly review of edits made with VisualEditor.May 28 2015, 5:37 PM
gerritbot added a comment.May 28 2015, 5:44 PM

Change 214385 merged by jenkins-bot:
Use more appropriate RecentChange_save hook for tagging

https://gerrit.wikimedia.org/r/214385

Jdforrester-WMF mentioned this in rEVED4be4497fac88: Use more appropriate RecentChange_save hook for tagging.May 28 2015, 5:44 PM
gerritbot added a comment.May 28 2015, 5:44 PM

Change 214390 merged by jenkins-bot:
Use more appropriate RecentChange_save hook for tagging

https://gerrit.wikimedia.org/r/214390

Jdforrester-WMF mentioned this in rEVEDc665e2811b32: Use more appropriate RecentChange_save hook for tagging.May 28 2015, 5:45 PM
gerritbot added a comment.May 28 2015, 5:46 PM

Change 214386 merged by jenkins-bot:
Use more appropriate RecentChange_save hook for tagging

https://gerrit.wikimedia.org/r/214386

Jdforrester-WMF mentioned this in rEVED3ff3f9703670: Use more appropriate RecentChange_save hook for tagging.May 28 2015, 5:46 PM
Jdforrester-WMF closed this task as Resolved.May 28 2015, 6:28 PM
Jdforrester-WMF assigned this task to aaron.
Jdforrester-WMF added projects: VisualEditor, VisualEditor 2014/15 Q4 blockers, Regression, WMF-deploy-2015-05-13_(1.26wmf6), WMF-deploy-2015-05-20_(1.26wmf7), WMF-deploy-2015-05-27_(1.26wmf8).
Jdforrester-WMF removed a project: Patch-For-Review.
• gpaumier moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.May 28 2015, 6:39 PM
• Elitre subscribed.May 28 2015, 7:21 PM
Jdforrester-WMF edited a custom field.May 28 2015, 8:38 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
• gpaumier moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.May 29 2015, 8:30 PM
• gpaumier moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Jun 4 2015, 3:12 PM
KartikMistry reopened this task as Open.Jun 5 2015, 4:25 AM

contenttranslation tag still not working. See: https://es.wikipedia.org/w/index.php?title=Especial:CambiosRecientes&tagfilter=contenttranslation

Pginer-WMF subscribed.Jun 5 2015, 7:10 AM

HHVM is not working either: https://es.wikipedia.org/w/index.php?title=Especial:CambiosRecientes&tagfilter=HHVM

aaron added a comment.Jun 5 2015, 5:27 PM
In T100439#1340394, @Pginer-WMF wrote:

HHVM is not working either: https://es.wikipedia.org/w/index.php?title=Especial:CambiosRecientes&tagfilter=HHVM

That tag was disabled and removed from edits a while back.

gerritbot added a comment.Jun 5 2015, 6:02 PM

Change 216140 had a related patch set uploaded (by Aaron Schulz):
Defer RC tag addition in the publish API

https://gerrit.wikimedia.org/r/216140

gerritbot added a project: Patch-For-Review.Jun 5 2015, 6:02 PM
Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Jun 5 2015, 6:57 PM
gerritbot added a comment.Jun 5 2015, 9:37 PM

Change 216140 merged by jenkins-bot:
Defer RC tag addition in the publish API

https://gerrit.wikimedia.org/r/216140

aaron mentioned this in rECTX29f6e4957963: Defer RC tag addition in the publish API.Jun 5 2015, 9:38 PM
Diffusion mentioned this in rMEXT99dd2292e15b: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Jun 5 2015, 9:38 PM
Nikerabbit subscribed.Jun 8 2015, 6:59 AM

If the above patch fixes the issue, does it mean that we have permanently lost the tags on some articles unless manually re-applied on them? Or if the above patch does not fix the issue, what does?

TheDJ added subscribers: Halfak, TheDJ.Jun 8 2015, 7:34 AM

I'm wondering if this has affected the work of @Halfak and his VE analysis.

• Elitre added a comment.EditedJun 8 2015, 8:38 AM

@TheDJ, luckily not, as per T101270.

• Forrestbot added a project: WMF-deploy-2015-06-09_(1.26wmf9).Jun 8 2015, 5:30 PM
• Forrestbot subscribed.
Jdforrester-WMF added a comment.Jun 9 2015, 3:41 PM

How many more tags are still broken, or can this be re-closed?

Nikerabbit mentioned this in T101864: Add missing contenttranslation tag to published articles.Jun 9 2015, 5:44 PM
Ciencia_Al_Poder added a comment.Jun 9 2015, 7:00 PM
In T100439#1344844, @Nikerabbit wrote:

If the above patch fixes the issue, does it mean that we have permanently lost the tags on some articles unless manually re-applied on them? Or if the above patch does not fix the issue, what does?

From my understanding, the problem is that tags were lost on the RecentChanges entry, but not on the page history. Please, correct me if I'm wrong.

TTO subscribed.Jun 11 2015, 8:44 AM
Nemo_bis subscribed.Jun 12 2015, 11:06 PM
Jdforrester-WMF moved this task from FY 18-19 Q3/Q4 to TR0: Interrupt on the VisualEditor board.Jun 18 2015, 1:30 AM
Jdforrester-WMF closed this task as Resolved.Jun 18 2015, 1:40 AM

No response, so I'm assuming everyone that cares has fixed their issue.

nshahquinn-wmf mentioned this in T101270: Backfill rctag data for VisualEditor from 2015-05-23–2015-05-28.Jun 24 2015, 5:37 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Ciencia_Al_Poder mentioned this in T108538: List of modifications are empty for tags defined manually by users or bots.Aug 9 2015, 7:37 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM
Nemo_bis added a project: ContentTranslation.Nov 23 2015, 9:22 AM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits