Page MenuHomePhabricator
Create Task
Maniphest T101169

[Usability] Convert the pop-over suggestions list to be an embedded search widget in the link inspector
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Move to a search widget instead of auto suggest widget in link inspector

auto-suggest-tosearch.png (1×2 px, 320 KB)

Details

SubjectRepoBranchLines +/-
MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidgetmediawiki/extensions/VisualEditormaster+50 -25
mediawiki.widgets: Create TitleSearchWidgetmediawiki/coremaster+481 -304
[BREAKING CHANGE] LinkAnnotationWidget: Abstract .text property to getTextInputWidgetVisualEditor/VisualEditormaster+23 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Nirzar created this task.Jun 2 2015, 9:05 PM
• Nirzar raised the priority of this task from to Needs Triage.
• Nirzar updated the task description. (Show Details)
• Nirzar added projects: VisualEditor 2014/15 Q4 blockers, Design, VisualEditor.
• Nirzar added a parent task: T101166: Address usability problems in link inspector (tracking).
• Nirzar added subscribers: Aklapper, • Nirzar.
Jdforrester-WMF triaged this task as High priority.Jun 3 2015, 5:42 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Jun 3 2015, 6:09 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Jun 3 2015, 10:00 PM
Jdforrester-WMF renamed this task from [Usability] convert the auto suggest widget to search widget in link inspector to [Usability] Convert the pop-over suggestions list to be an embedded search widget in the link inspector.Jun 16 2015, 8:06 PM
Jdforrester-WMF edited a custom field.
Esanders subscribed.Jun 16 2015, 8:24 PM

We need to check how this looks where the screen is a little smaller, and there are 5 results. We actually can get more than 5 results when there are redirects. Is the idea that the dialog resizes as the results change?

• Nirzar added a comment.Jun 16 2015, 8:28 PM

If we consider the height of this dialog to be max 400px which should be fit on smallest screen with enough article padding around it, we can fit 4 and a half list items in this. and if we have cut of at half of last list item, it suggests that the list is scrollable internally.

Jdforrester-WMF moved this task from TR6: Visual diffs to Needs Discussion/Analysis on the VisualEditor board.Jun 18 2015, 12:33 AM
Esanders added a comment.Jun 24 2015, 1:50 PM

We need some more views with different results sets. How does this look with 0,1,2,3,4,5 search results? Do we leave whitespace or expand the dialog? What if we expand off the bottom of the screen?

Jdforrester-WMF added a subscriber: Krenair.Jun 26 2015, 3:27 PM
Jdforrester-WMF edited projects, added VisualEditor 2015/16 Q1 blockers; removed VisualEditor 2014/15 Q4 blockers.Jun 29 2015, 8:41 PM
Jdforrester-WMF moved this task from Nominated to Backlog: T2+ on the VisualEditor 2015/16 Q1 blockers board.Jun 30 2015, 7:12 PM
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
Jdforrester-WMF removed a parent task: T101166: Address usability problems in link inspector (tracking).Aug 20 2015, 11:24 PM
Jdforrester-WMF added a parent task: T113636: In mobile, link suggestions only show on focus, go away when you close the keyboard (e.g. to see more of them).Sep 24 2015, 6:26 PM
Jdforrester-WMF added a parent task: T113643: Sometimes in mobile, link suggestions open up in the wrong place, off to the side and not attached to the text box.
gerritbot subscribed.Sep 25 2015, 8:07 PM

Change 241143 had a related patch set uploaded (by Esanders):
LinkAnnotationWidget: Abstract .text property to getInputWidget

https://gerrit.wikimedia.org/r/241143

gerritbot added a project: Patch-For-Review.Sep 25 2015, 8:07 PM
gerritbot added a comment.Sep 25 2015, 8:46 PM

Change 241228 had a related patch set uploaded (by Esanders):
mediawiki.widgets: Create TitleSearchWidget

https://gerrit.wikimedia.org/r/241228

gerritbot added a comment.Sep 25 2015, 8:48 PM

Change 241229 had a related patch set uploaded (by Esanders):
MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidget

https://gerrit.wikimedia.org/r/241229

gerritbot added a comment.Sep 26 2015, 11:21 AM

Change 241143 merged by jenkins-bot:
[BREAKING CHANGE] LinkAnnotationWidget: Abstract .text property to getTextInputWidget

https://gerrit.wikimedia.org/r/241143

Esanders mentioned this in rGVED18e46b60526f: [BREAKING CHANGE] LinkAnnotationWidget: Abstract .text property to….Sep 26 2015, 11:21 AM
gerritbot added a comment.Sep 26 2015, 12:01 PM

Change 241228 merged by jenkins-bot:
mediawiki.widgets: Create TitleSearchWidget

https://gerrit.wikimedia.org/r/241228

Esanders mentioned this in rMW8aeef44d7d5e: mediawiki.widgets: Create TitleSearchWidget.Sep 26 2015, 12:02 PM
Esanders mentioned this in T113643: Sometimes in mobile, link suggestions open up in the wrong place, off to the side and not attached to the text box.Sep 26 2015, 5:10 PM
Esanders mentioned this in T113636: In mobile, link suggestions only show on focus, go away when you close the keyboard (e.g. to see more of them).
gerritbot added a comment.Sep 28 2015, 9:10 PM

Change 241229 merged by jenkins-bot:
MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidget

https://gerrit.wikimedia.org/r/241229

Esanders mentioned this in rEVEDf814ea719b8b: MWLinkAnnotationInspector: Use TitleSearchWidget instead of TitleInputWidget.Sep 28 2015, 9:11 PM
Jdforrester-WMF closed this task as Resolved.Sep 28 2015, 10:15 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed Patch-For-Review.
Jdforrester-WMF added projects: VisualEditor-MediaWiki-Links, User-notice.Sep 29 2015, 7:02 PM
ReleaseTaggerBot added projects: MW-1.27-release, MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 9:24 PM
greg edited projects, added MW-1.27-release-notes; removed MW-1.27-release.Sep 29 2015, 10:28 PM
Jdforrester-WMF removed a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:49 AM
• Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Oct 1 2015, 9:23 PM
Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Oct 8 2015, 8:23 AM
Johan moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Oct 14 2015, 2:49 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits