Page MenuHomePhabricator
Create Task
Maniphest T110007

ContentTranslation adds several references with different name parameters, but the same content or same name and different content
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In this edit, CX produced completely messed up references:

  • Several references with the same content but different names. Example with the first 2 references, named IDB and F1 with exactly the same content
  • Several references with the same name but different content. Example with reference named F1

Please, deactivate this tool until the many major bugs are fixed...

Details

SubjectRepoBranchLines +/-
Fix: References are adapted with same contentmediawiki/extensions/ContentTranslationwmf/1.26wmf21+8 -7
Fix: References are adapted with same contentmediawiki/extensions/ContentTranslationwmf/1.26wmf20+8 -7
Fix: References are adapted with same contentmediawiki/extensions/ContentTranslationmaster+8 -7
Customize query in gerrit

Related Objects

Event Timeline

NicoV created this task.Aug 24 2015, 6:41 AM
NicoV raised the priority of this task from to Needs Triage.
NicoV updated the task description. (Show Details)
NicoV added a project: ContentTranslation.
NicoV subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2015, 6:41 AM
NicoV added a comment.Aug 24 2015, 6:57 AM

Other example

This tool is producing completely messed up articles, that requires a lot of human work to clean up.
Example of an article produced with many, many problems, none of them fixed by the contributor using CX.

Amire80 renamed this task from ContentTranslation messing up references to ContentTranslation adds several references with different name parameters, but the same content.Aug 24 2015, 7:26 AM
Amire80 triaged this task as High priority.
Amire80 set Security to None.
NicoV added a subscriber: Amire80.Aug 24 2015, 8:57 AM

@Amire80

The new title for this task hides the most important bug: that several references are added with the same name parameter, but with different content... which means that it's not the correct references that are visible in the article...

Amire80 renamed this task from ContentTranslation adds several references with different name parameters, but the same content to ContentTranslation adds several references with different name parameters, but the same content or same name and different content.Aug 24 2015, 9:23 AM
Amire80 added a comment.Aug 24 2015, 10:22 AM

Very curious.

I am able to reproduce this problem when I translate from English to French - https://fr.wikipedia.org/w/index.php?title=Utilisateur:Amire80/Factorio_01&oldid=118019658 . I couldn't reproduce it in other languages. Could be something special about French Wikipedia or its {{Cite web}} template. I'm trying to debug this.

Amire80 moved this task from Needs Triage to CX6 on the ContentTranslation board.Aug 24 2015, 6:36 PM
Amire80 added a project: ContentTranslation-Release6.Aug 24 2015, 8:16 PM
Amire80 moved this task from Backlog to Bugs on the ContentTranslation-Release6 board.
Arrbee subscribed.Aug 25 2015, 7:05 AM

Timeboxed for investigation: 25 Aug. Candidate for LE-CX6-Sprint 3

Arrbee added a project: LE-CX6-Sprint 3.Aug 26 2015, 11:37 AM
Amire80 moved this task from Backlog to In Progress on the LE-CX6-Sprint 3 board.Aug 27 2015, 8:24 AM
Amire80 claimed this task.Aug 28 2015, 6:34 AM
Amire80 edited a custom field.
Amire80 added a comment.Aug 28 2015, 10:55 AM

A similar issue in Afrikaans: https://af.wikipedia.org/wiki/Walmer-landgoed

Amire80 mentioned this in T104066: ContentTranslation's postMT hook is fired twice even though no MT is done.Sep 2 2015, 4:19 AM
Amire80 added a comment.Sep 2 2015, 4:23 AM

Yesterday I saw that it happens in Hebrew as well: https://he.wikipedia.org/w/index.php?title=%D7%91%D7%A0%D7%99_%D7%95%D7%92%27%D7%95%D7%9F&oldid=17427789

The regression probably started at https://gerrit.wikimedia.org/r/#/c/230485/ , but some odd things happen when I am trying to debug. That function runs at least twice (probably because of T104066), the first time with an empty paragraph, which is pointless. It's also very unclear to me when templates is it supposed to add to the templates array. Help will be appreciated - this is pretty urgent.

Amire80 added a comment.Sep 2 2015, 4:33 AM

(I can consistently reproduce this by translating [[Factorio]] from English to French on my local wiki.)

santhosh subscribed.Sep 2 2015, 5:53 AM
santhosh claimed this task.Sep 2 2015, 6:18 AM
gerritbot subscribed.Sep 2 2015, 7:31 AM

Change 235413 had a related patch set uploaded (by Santhosh):
Fix: References are adapted with same content

https://gerrit.wikimedia.org/r/235413

gerritbot added a project: Patch-For-Review.Sep 2 2015, 7:31 AM
santhosh moved this task from In Progress to In Review on the LE-CX6-Sprint 3 board.Sep 2 2015, 11:29 AM
gerritbot added a comment.Sep 2 2015, 11:52 AM

Change 235413 merged by jenkins-bot:
Fix: References are adapted with same content

https://gerrit.wikimedia.org/r/235413

Nikerabbit mentioned this in rECTXb9ee8f376ac4: Fix: References are adapted with same content.Sep 2 2015, 11:52 AM
Diffusion mentioned this in rMEXTe0ceab7856b0: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 2 2015, 11:53 AM
gerritbot added a comment.Sep 2 2015, 11:53 AM

Change 235441 had a related patch set uploaded (by KartikMistry):
Fix: References are adapted with same content

https://gerrit.wikimedia.org/r/235441

gerritbot added a comment.Sep 2 2015, 11:54 AM

Change 235442 had a related patch set uploaded (by KartikMistry):
Fix: References are adapted with same content

https://gerrit.wikimedia.org/r/235442

• Forrestbot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 2 2015, 12:00 PM
gerritbot added a comment.Sep 2 2015, 3:06 PM

Change 235441 merged by jenkins-bot:
Fix: References are adapted with same content

https://gerrit.wikimedia.org/r/235441

santhosh mentioned this in rMW6c85ad3aa34f: Updated mediawiki/core Project: mediawiki/extensions/ContentTranslation….Sep 2 2015, 3:06 PM
KartikMistry mentioned this in rECTX83baeff60757: Fix: References are adapted with same content.Sep 2 2015, 3:06 PM
gerritbot added a comment.Sep 2 2015, 3:06 PM

Change 235442 merged by jenkins-bot:
Fix: References are adapted with same content

https://gerrit.wikimedia.org/r/235442

KartikMistry mentioned this in rECTXdbc78fc0c3ae: Fix: References are adapted with same content.Sep 2 2015, 3:06 PM
santhosh mentioned this in rMW297b055c9d9c: Updated mediawiki/core Project: mediawiki/extensions/ContentTranslation….Sep 2 2015, 3:06 PM
• Forrestbot added projects: WMF-deploy-2015-09-01_(1.26wmf21), WMF-deploy-2015-08-25_(1.26wmf20).Sep 2 2015, 4:00 PM
KartikMistry moved this task from In Review to Done on the LE-CX6-Sprint 3 board.Sep 3 2015, 3:22 AM
Amire80 closed this task as Resolved.Sep 3 2015, 6:59 AM
Amire80 removed a project: Patch-For-Review.

Resolved, deployed, tested.

matej_suchanek added a project: User-notice.Sep 4 2015, 11:31 AM
matej_suchanek moved this task from To Triage to In current Tech/News draft on the User-notice board.
matej_suchanek removed a subscriber: gerritbot.
Arrbee added a project: Essential-Work.Sep 7 2015, 12:00 PM
Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Sep 9 2015, 9:11 AM
Johan moved this task from Recently announced in Tech/News to To Triage on the User-notice board.
Johan moved this task from To Triage to Already announced/Archive on the User-notice board.Sep 17 2015, 4:07 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits