Page MenuHomePhabricator
Create Task
Maniphest T181651

Add the file hash value (sha1) to the action=info page for files uploaded in MediaWiki
Closed, ResolvedPublic
Actions

Description

It would be nice if img_sha1 was displayed as a hexadecimal string (same as [[ https://en.wikipedia.org/wiki/Sha1sum | sha1sum ]]) on the information page for files uploaded in MediaWiki.

That way, users could verify their file is the same as the file that they uploaded.

Details

SubjectRepoBranchLines +/-
Convert the sha1 value from base-36 to base-16mediawiki/coremaster+4 -3
Follow-up 5aea96df: Add release notes for File SHA1 displaymediawiki/coremaster+2 -0
Display the file sha1 value in the file info pagemediawiki/coremaster+14 -0
Customize query in gerrit

Related Objects

Event Timeline

Dispenser created this task.Nov 29 2017, 5:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2017, 5:26 PM
Dispenser edited projects, added MediaWiki-File-management, MediaWiki-Special-pages, good first task; removed SRE-swift-storage.Nov 29 2017, 5:36 PM
Dispenser updated the task description. (Show Details)
Restricted Application added a project: Multimedia. · View Herald TranscriptNov 29 2017, 5:36 PM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
Tgr subscribed.Nov 29 2017, 9:31 PM

Could be a Google-Code-in-2017 task probably.

• MZMcBride subscribed.Nov 29 2017, 11:18 PM
Framawiki added a project: Google-Code-in-2017.Dec 2 2017, 2:17 PM
Framawiki moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2017 board.
Framawiki subscribed.
Aklapper renamed this task from Add file hash to action=info to Add the file hash value (sha1) to the action=info page for files uploaded in MediaWiki.Dec 6 2017, 5:26 PM
Aklapper triaged this task as Low priority.
Aklapper updated the task description. (Show Details)
Ebe123 subscribed.Dec 28 2017, 3:54 PM

I'd be willing to mentor this task.

RazeSoldier subscribed.Dec 28 2017, 4:42 PM
Ebe123 added a comment.Dec 28 2017, 5:02 PM

https://codein.withgoogle.com/dashboard/tasks/5677924248190976/

Ebe123 moved this task from Missing mentors to Imported in GCI Site on the Google-Code-in-2017 board.Dec 28 2017, 8:33 PM
RazeSoldier added a comment.EditedDec 29 2017, 4:50 AM

I have a question.
Get img_sha1 value from the database? Or, calculate sha1 when visiting the image info page.

zhuyifei1999 subscribed.Dec 29 2017, 5:13 AM
In T181651#3863091, @RazeSoldier wrote:

Get img_sha1 value from the database? Or, calculate sha1 when visiting the image info page.

Get img_sha1 value from the database... when visiting the image info page.

Dispenser updated the task description. (Show Details)Dec 29 2017, 11:36 AM
RazeSoldier claimed this task.Dec 29 2017, 1:50 PM
Ebe123 added a comment.Dec 29 2017, 4:59 PM

你是GCI的学生吗？If so, please register at https://codein.withgoogle.com/ . 谢谢！

Aklapper edited projects, added Patch-For-Review; removed Google-Code-in-2017.Dec 29 2017, 5:33 PM

https://gerrit.wikimedia.org/r/#/c/400695/ exists so I'm adding Patch-For-Review.
I'm also removing the Google-Code-in-2017 tag as this task was not claimed on the GCI website.)

RazeSoldier added a comment.Dec 30 2017, 1:48 AM
In T181651#3863610, @Ebe123 wrote:

你是GCI的学生吗？If so, please register at https://codein.withgoogle.com/ . 谢谢！

No, I am not a GCI student. I am just an ordinary student.

Liuxinyu970226 subscribed.Dec 30 2017, 2:07 AM
gerritbot subscribed.Dec 30 2017, 4:08 AM

Change 400695 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/core@master] Display the file sha1 value in the file info page

https://gerrit.wikimedia.org/r/400695

Ebe123 added a comment.Dec 30 2017, 4:31 AM

没关系。Removed it from GCI.

RazeSoldier added a comment.EditedJan 3 2018, 2:39 AM

The change need code-review. :)

gerritbot added a comment.Jan 3 2018, 12:44 PM

Change 400695 merged by jenkins-bot:
[mediawiki/core@master] Display the file sha1 value in the file info page

https://gerrit.wikimedia.org/r/400695

RazeSoldier closed this task as Resolved.Jan 3 2018, 12:51 PM
RazeSoldier removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 3 2018, 1:01 PM
Liuxinyu970226 unsubscribed.Jan 3 2018, 1:47 PM
Krinkle removed a project: MediaWiki-Special-pages.Jan 4 2018, 11:58 PM
gerritbot added a comment.Jan 18 2018, 7:20 AM

Change 404915 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/core@master] Diplay the file sha1 value in the file info page

https://gerrit.wikimedia.org/r/404915

gerritbot added a project: Patch-For-Review.Jan 18 2018, 7:20 AM
gerritbot added a comment.Jan 19 2018, 6:47 PM

Change 404915 merged by jenkins-bot:
[mediawiki/core@master] Follow-up 5aea96df: Add release notes for File SHA1 display

https://gerrit.wikimedia.org/r/404915

RazeSoldier removed a project: Patch-For-Review.Jan 19 2018, 6:54 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 19 2018, 7:01 PM
Dispenser reopened this task as Open.Jan 25 2018, 2:39 AM

@RazeSoldier has done nice work with the patch, but it should be in hexadecimal to be consistent with the API (and every sha1sum tool).

gerritbot added a comment.Jan 25 2018, 5:08 AM

Change 406154 had a related patch set uploaded (by 星耀晨曦; owner: RazeSoldier):
[mediawiki/core@master] Convert the sha1 value from base-36 to base-16

https://gerrit.wikimedia.org/r/406154

gerritbot added a project: Patch-For-Review.Jan 25 2018, 5:08 AM
RazeSoldier moved this task from Backlog to Doing on the good first task board.Jan 25 2018, 8:22 AM
gerritbot added a comment.Jan 26 2018, 6:54 AM

Change 406154 merged by jenkins-bot:
[mediawiki/core@master] Convert the sha1 value from base-36 to base-16

https://gerrit.wikimedia.org/r/406154

RazeSoldier closed this task as Resolved.Jan 26 2018, 8:26 AM
RazeSoldier removed a project: Patch-For-Review.
RazeSoldier added a project: User-notice.Jan 31 2018, 4:59 PM

The info page for File pages now displays the file's base-16 SHA1 hash value in the table of basic information.

Johan moved this task from To Triage to Already announced/Archive on the User-notice board.Jan 31 2018, 11:56 PM
Johan moved this task from Already announced/Archive to In current Tech/News draft on the User-notice board.
• Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Feb 8 2018, 8:27 PM
RandomDSdevel awarded a token.Feb 13 2018, 2:44 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits