Page MenuHomePhabricator
Create Task
Maniphest T19099

"Discussion" tab should have indication of nonexistent target page (other than color)
Closed, ResolvedPublic
Actions

Assigned To
Albert221
Authored By
• bzimport
Jan 20 2009, 11:46 PM
Tags
Referenced Files
F5441: Screen_Shot_2012-05-25_at_5.37.53_AM.png
Nov 21 2014, 10:29 PM
F5442: Screen_Shot_2012-05-25_at_5.39.20_AM.png
Nov 21 2014, 10:29 PM
F5440: bug17099_2.patch
Nov 21 2014, 10:29 PM
Subscribers
Aklapper
Bawolff
Fz-29
gerritbot
hoo
Mvolz
Nemo_bis
View All 10 Subscribers
Tokens
"Orange Medal" token, awarded by Krinkle.

Description

Author: michael

Description:
When a page has no discussion yet, this status is indicated by the red colour of the “Discussion” link in the tab at the top, but not by other means. This is an accessibility blocker, because information conveyed by colour must also be indicated in text or markup: Priority 1 in WCAG 1.0 (http://www.w3.org/TR/WCAG10/wai-pageauth.html#tech-color-convey), Level A in WCAG 2.0 (http://www.w3.org/TR/WCAG20/#visual-audio-contrast-without-color).

This could be fixed simply by appending “(page does not exist)” to the title attribute as is done for red links in the body of a page, or by changing the title from “Discussion about the content page” to “Start discussion about the content page”.

Screen_Shot_2012-05-25_at_5.37.53_AM.png (88×421 px, 14 KB)
Discussion tab in Vector for talk page (tooltip does not indicate inexistent state)
Screen_Shot_2012-05-25_at_5.39.20_AM.png (95×356 px, 23 KB)
Inline link in Vector to an inexistent page (tooltip indicating page does not exist)

Details

Reference
bz17099
SubjectRepoBranchLines +/-
Add text to tab links telling if they do existmediawiki/coremaster+36 -9
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:29 PM
• bzimport added projects: MediaWiki-User-Interface, Accessibility.
• bzimport set Reference to bz17099.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jan 20 2009, 11:46 PM
• bzimport added a comment.Oct 7 2011, 10:57 AM

Nx.devnull wrote:

Wrap tooltip in 'red-link-title'

A patch that puts "(page does not exist)" into the title by wrapping the tooltip in 'red-link-title', the message used to generate the tooltip for red links.

attachment bug17099.patch ignored as obsolete

• bzimport added a comment.Oct 7 2011, 11:04 AM

sumanah wrote:

Thanks for the patch, Nx.devnull. I attached the keywords "patch" and "need-review" so other developers notice your patch and review it.

• bzimport added a comment.Oct 7 2011, 11:09 AM

Nx.devnull wrote:

Wrap tooltips of my page / my talk links too

Just a small change so that the my page / my talk links in the personal toolbar get it too.

Attached:

bug17099_2.patch6 KBDownload

• bzimport added a comment.May 25 2012, 3:04 AM

sumanah wrote:

Nikola, thank you for your patch. Are you interested in using developer access to directly suggest it into our Git source control system? Sorry for the wait, and this would get it reviewed faster.

For reference:

https://www.mediawiki.org/wiki/Developer_access

https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch

Krinkle added a comment.May 25 2012, 3:40 AM

Created attachment 10649
Screenshot of Discussion tab in Vector for inexistent talk page

Attached:

Screen_Shot_2012-05-25_at_5.37.53_AM.png (88×421 px, 14 KB)

Krinkle added a comment.May 25 2012, 3:40 AM

Created attachment 10650
Screenshot of inline link in Vector to an inexistent page (tooltip)

Attached:

Screen_Shot_2012-05-25_at_5.39.20_AM.png (95×356 px, 23 KB)

Nemo_bis added a comment.Mar 10 2013, 11:47 AM

To clarify (it confused me a bit): this bug is only asking something consistent with how red links behave normally, as Krinkle's screenshots show.

gerritbot added a comment.May 12 2013, 7:03 PM

Related URL: https://gerrit.wikimedia.org/r/63387 (Gerrit Change Ie3c12c66989665326cc10ea9a0bc1d569026faa0)

gerritbot added a comment.Sep 26 2014, 2:03 PM

Change 63387 abandoned by Luis Felipe Schenone:
Add "(page does not exist)" to non-existent talk pages' tooltip

Reason:
Master changed too much. Better to start a new change.

https://gerrit.wikimedia.org/r/63387

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2016, 11:11 PM
TheDJ added a project: good first task.Nov 9 2017, 2:20 PM
TheDJ subscribed.

This should be a pretty easy task honestly, someone just needs to brush up that patch again.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptNov 9 2017, 2:20 PM
TheDJ moved this task from Unsorted to Tooltip on the Accessibility board.Nov 9 2017, 2:22 PM
Krinkle updated the task description. (Show Details)Nov 10 2017, 2:20 AM
Krinkle added a project: Vector (legacy skin).
Krinkle removed a subscriber: • wikibugs-l-list.
Krinkle unsubscribed.
Mvolz added a project: Google-Code-in-2017.Nov 25 2017, 6:33 PM
Mvolz subscribed.

Maybe good for Google-Code-in-2017?

Mvolz moved this task from Proposed tasks to Missing mentors on the Google-Code-in-2017 board.Nov 25 2017, 6:35 PM
Mvolz added a comment.Nov 25 2017, 6:50 PM

Could anyone mentor?

Fz-29 subscribed.Jan 2 2018, 9:15 PM

@Mvolz @Aklapper I would like to mentor this task.

Aklapper moved this task from Missing mentors to Imported in GCI Site on the Google-Code-in-2017 board.Jan 2 2018, 10:05 PM

Thanks! Published as https://codein.withgoogle.com/tasks/6286248249393152/

gerritbot subscribed.Jan 3 2018, 2:38 PM

Change 401733 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/core@master] Add text to tab links telling if they do exist

https://gerrit.wikimedia.org/r/401733

gerritbot added a project: Patch-For-Review.Jan 3 2018, 2:38 PM
Albert221 claimed this task.Jan 3 2018, 3:18 PM
Fz-29 added a comment.Jan 4 2018, 7:19 PM

I'm trying to test this patch. Can anyone else also test it on their systems?
@Mvolz Can you also test it, please?

Fz-29 added a comment.Jan 4 2018, 8:16 PM

@Mvolz and @Aklapper the patch works fine in my dev environment.
The code looks fine too. Should we approve the Google Code-in task ?

Mvolz added a comment.Jan 4 2018, 8:29 PM
In T19099#3876447, @Fz-29 wrote:

@Mvolz and @Aklapper the patch works fine in my dev environment.
The code looks fine too. Should we approve the Google Code-in task ?

You should first review it on gerrit, and then approve ^-^.

gerritbot added a comment.Jan 8 2018, 7:24 PM

Change 401733 merged by jenkins-bot:
[mediawiki/core@master] Add text to tab links telling if they do exist

https://gerrit.wikimedia.org/r/401733

matmarex closed this task as Resolved.Jan 8 2018, 7:30 PM
matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 8 2018, 8:01 PM
Krinkle awarded a token.Jan 11 2018, 8:30 PM
Aklapper removed a parent task: T2367: Several markup accessibility issues.Dec 9 2019, 1:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits