Page MenuHomePhabricator
Create Task
Maniphest T53429

TemplateData: Display a useful message instead of an empty table for templates that take no parameters
Closed, ResolvedPublic
Actions

Description

Currently, if you use TemplateData for a template without any parameters, you still have to create an empty "params" in the JSON (not really important), but you also end up with a "Template parameters" table with just the title line (Parameter Description Type Default Status).

Rather than displaying an empty table, I think it would be better to display no table at all, or a simple message saying that no parameters are defined for this template.

Version: unspecified
Severity: minor

Details

Reference
bz51429
SubjectRepoBranchLines +/-
Display a message when no parameters are definedmediawiki/extensions/TemplateDatamaster+15 -0
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:01 AM
• bzimport added a project: TemplateData.
• bzimport set Reference to bz51429.
NicoV created this task.Jul 16 2013, 7:36 AM
Jdforrester-WMF added a comment.Apr 28 2014, 6:52 PM
  • Bug 62417 has been marked as a duplicate of this bug. ***
Ricordisamoa subscribed.Jan 12 2015, 8:50 PM
Jdforrester-WMF moved this task from Backlog to Next-up on the TemplateData board.Jan 12 2015, 9:16 PM
Lokal_Profil subscribed.Jan 15 2015, 2:05 PM

It would also be useful if you could set "no parameters" in the TemplateData so that VisualEditor does not suggest adding a parameter for these templates.

gerritbot subscribed.Feb 19 2015, 1:12 AM

Change 191518 had a related patch set uploaded (by Mooeypoo):
Display a message when no parameters are defined

https://gerrit.wikimedia.org/r/191518

Patch-For-Review

Mooeypoo claimed this task.Feb 19 2015, 1:12 AM
Mooeypoo moved this task from Next-up to Doing on the TemplateData board.Feb 19 2015, 1:17 AM
Jdforrester-WMF closed this task as Resolved.Feb 19 2015, 1:48 AM
Jdforrester-WMF added a project: WMF-deploy-2015-02-25_(1.25wmf19).
Jdforrester-WMF set Security to None.
gerritbot added a comment.Feb 19 2015, 1:48 AM

Change 191518 merged by jenkins-bot:
Display a message when no parameters are defined

https://gerrit.wikimedia.org/r/191518

Mooeypoo mentioned this in rETDA4757a83f883b: Display a message when no parameters are defined.Feb 19 2015, 1:48 AM
Etonkovidova subscribed.Feb 23 2015, 11:03 PM

The fix in beta:

Screen_Shot_2015-02-23_at_2.59.41_PM.png (172×670 px, 23 KB)

vs test2:

Screen_Shot_2015-02-23_at_2.59.25_PM.png (109×525 px, 13 KB)

Mooeypoo mentioned this in rMEXTd36c0da6e209: Updated mediawiki/extensions Project: mediawiki/extensions/TemplateData….Mar 11 2015, 6:27 AM
• Whatamidoing-WMF mentioned this in T64417: TemplateData: Be able to specify a "no parameters accepted" definition.Jun 11 2015, 10:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits