Page MenuHomePhabricator
Create Task
Maniphest T64147

Add an option in TemplateData to specify desired wikitext whitespace formatting of parameters
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Note: This will not change the behaviour of various software components immediately. Instead, they will each need to be updated – see the blocked tasks.

See documentation for the format parameter, at:

However, here are two examples of how to add the parameter, at beta cluster:

Original title: html2wt: new templates should display one parameter per line

I understand this was partly discussed in T53175: Parsoid does not add newlines between parameters in new template invocations, making wikitext difficult to read (with suggestions about how to handle the issue), but whatever happened next didn't seem to affect this :)

If you check out the source of https://it.wikipedia.org/w/index.php?title=Utente:Elitre_(WMF)/Sandbox_VE&oldid=64531360 , you'll notice a couple of templates at the top. Those were added with VE, and are collapsed, whereas editors on it.wp would want those kind of templates (which are basically infoboxes) to always display one parameter per line, no matter what the length of the template is.

Version: unspecified
Severity: normal
See Also: T53003

Details

Reference
bz62147
SubjectRepoBranchLines +/-
Introduce new 'format' template propertymediawiki/extensions/TemplateDatamaster+189 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:52 AM
• bzimport added a project: Parsoid.
• bzimport set Reference to bz62147.
• Elitre created this task.Mar 3 2014, 3:47 PM
ssastry added a comment.Mar 4 2014, 4:52 PM

This will require TemplateData annotations since other editors will complain if we started rendering cite templates (for ex.) with 1 parameter per line always. So, parsoid needs information about what templates use what style. To be discussed whether Parsoid will read this info from TemplateData sources directly or whether VE will pass along this info to Parsoid.

• Whatamidoing-WMF renamed this task from html2wt: new templates should display one parameter per line to Add an option in TemplateData to specify whether parameters for each template should be recorded in wikitext all on one line or with each parameter on a separate line.Aug 5 2015, 10:57 PM
• Whatamidoing-WMF updated the task description. (Show Details)
• Whatamidoing-WMF added a project: TemplateData.
• Whatamidoing-WMF set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2015, 10:57 PM
Jdforrester-WMF mentioned this in T111674: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions.Sep 8 2015, 6:35 PM
Trizek-WMF subscribed.Sep 8 2015, 6:53 PM
Sunpriat subscribed.Sep 9 2015, 10:04 AM
Jdforrester-WMF merged a task: T71682: VisualEditor: allow parameter per line in inserted templates.Sep 15 2015, 7:27 PM
Jdforrester-WMF added subscribers: nshahquinn-wmf, • Tbayer, Amire80 and 4 others.
• Elitre mentioned this in T64217: TemplateData: Provide information about preferred formatting of transclusions.Oct 19 2015, 11:26 AM
Jdforrester-WMF added a parent task: T111674: Parsoid on serialisation should use the `format` field from TemplateData if available to set the whitespace formatting of new/edited transclusions.Oct 19 2015, 4:57 PM
Jdforrester-WMF merged a task: T64217: TemplateData: Provide information about preferred formatting of transclusions.Oct 19 2015, 5:39 PM
Jdforrester-WMF added a parent task: T53003: Strip leading / trailing whitespace out of transclusion parameters, and try to match single / multi-line style.
Jdforrester-WMF added subscribers: Mvolz, gerritbot, Schnark and 5 others.
gerritbot added a comment.Oct 19 2015, 6:45 PM

Change 243138 had a related patch set uploaded (by Jforrester):
Introducing template format

https://gerrit.wikimedia.org/r/243138

gerritbot added a project: Patch-For-Review.Oct 19 2015, 6:45 PM
Krinkle renamed this task from Add an option in TemplateData to specify whether parameters for each template should be recorded in wikitext all on one line or with each parameter on a separate line to Add an option in TemplateData to specify desired wikitext whitespace formatting of parameters.Oct 19 2015, 6:48 PM
Jdforrester-WMF closed this task as Resolved.Nov 11 2015, 11:55 PM
Jdforrester-WMF assigned this task to eranroz.
Jdforrester-WMF edited projects, added VisualEditor, User-notice, VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, MW-1.27-release (WMF-deploy-2015-11-17_(1.27.0-wmf.7)); removed Patch-For-Review.
gerritbot added a comment.Nov 11 2015, 11:56 PM

Change 243138 merged by jenkins-bot:
Introduce new 'format' template property

https://gerrit.wikimedia.org/r/243138

Jdforrester-WMF edited a custom field.Nov 11 2015, 11:56 PM
Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.Nov 12 2015, 12:43 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Nov 16 2015, 6:52 PM
Tacsipacsi updated the task description. (Show Details)Nov 16 2015, 7:52 PM
Tacsipacsi mentioned this in T53003: Strip leading / trailing whitespace out of transclusion parameters, and try to match single / multi-line style.
AdHuikeshoven subscribed.Nov 16 2015, 9:24 PM
• Quiddity subscribed.Nov 16 2015, 9:41 PM

Please document the update in

(and link the update in the task description when done, because Tech/News links here.)
Thanks :-)

It seems to be described most clearly in https://gerrit.wikimedia.org/r/#/c/243138/13/Specification.md but I'm not sure.

Updating an example, so that there's a diff to refer to, would also be good. Perhaps https://www.mediawiki.org/wiki/Template:User_info#TemplateData

• Quiddity updated the task description. (Show Details)Nov 16 2015, 11:26 PM
• Quiddity updated the task description. (Show Details)
• Quiddity updated the task description. (Show Details)Nov 16 2015, 11:34 PM
In T64147#1809157, @Quiddity wrote:

Please document the update in

{{done}}

(and link the update in the task description when done, because Tech/News links here.)

{{done}}

Updating an example, so that there's a diff to refer to, would also be good. Perhaps https://www.mediawiki.org/wiki/Template:User_info#TemplateData

Can't do that, until the code is live! But I did update a couple at beta cluster:

Mvolz added a comment.EditedNov 16 2015, 11:47 PM

I'm not really sure this task is announcement worthy as setting the option
doesn't actually do anything yet. That's waiting on the parsoid change this
blocks.

• Quiddity added a comment.Nov 16 2015, 11:53 PM
In T64147#1809504, @Mvolz wrote:

I'm not really sure this task is announcement worthy as setting the option doesn't actually do anything yet. That's waiting on parsoid change this blocks.

Err, it was already announced, in the Tech/News that went out today: https://meta.wikimedia.org/wiki/Tech/News/2015/47 :-/
How far away are the parsoid changes?
Perhaps someone could update the description above, to give that ETA detail? (Because curious people will be arriving via Tech/News).

He7d3r subscribed.Nov 17 2015, 12:29 AM
• Quiddity updated the task description. (Show Details)Nov 17 2015, 2:30 AM
Ricordisamoa reopened this task as Open.Nov 17 2015, 9:35 AM

For the new format to be effective, it should allow specifying arbitrary spacing like "\n%s = %s", "%s=%s".

Mvolz added a comment.Nov 17 2015, 10:07 AM

@Ricordisamoa as per @Jdforrester-WMF's comment here:

https://phabricator.wikimedia.org/T64217#1650279

more elaborate ways of setting this was declined.

Mvolz closed this task as Resolved.Nov 17 2015, 10:07 AM
Akoopal subscribed.Nov 18 2015, 7:33 PM
Akoopal unsubscribed.Nov 18 2015, 7:36 PM
• Quiddity moved this task from Announce in next Tech/News to Already announced/Archive on the User-notice board.Nov 20 2015, 12:50 AM
AdHuikeshoven mentioned this in T119347: Enable VisualEditor for future newly registered users on Dutch Wikipedia.Nov 22 2015, 10:21 PM
• Quiddity updated the task description. (Show Details)Nov 23 2015, 5:22 PM
Jdforrester-WMF updated the task description. (Show Details)Nov 23 2015, 5:45 PM
Jdforrester-WMF updated the task description. (Show Details)
Ricordisamoa added a comment.Nov 28 2015, 9:22 PM
In T64147#1810398, @Mvolz wrote:

@Ricordisamoa as per @Jdforrester-WMF's comment here:

https://phabricator.wikimedia.org/T64217#1650279

more elaborate ways of setting this was declined.

Shouldn't the task be marked as declined too?

Jdforrester-WMF mentioned this in T53334: TemplateData: Hint that templates should have whitespace inserted after/before them (e.g. for message box notice templates).Jan 15 2016, 9:24 PM
Jdforrester-WMF moved this task from Backlog to Doing on the TemplateData board.
He7d3r merged a task: T85677: Allow parameters to be added in new lines.Feb 29 2016, 12:09 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits