Maniphest T74494

VisualEditor: Clicking on somewhere else in the document after opening a link inspector inside a slug throws error "TypeError: Cannot read property 'previousSibling' of undefined"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert a bullet list
3.Add some indentation
4.Now click on any slug that got created due to indentation
5.Open a link inspector on that position
6.While the link inspector is open, click somewhere else in the document to close the inspector

Observed Result:
The link inspector stays opened in that position and there is an error in the console:
TypeError: Cannot read property 'previousSibling' of undefined

See the screenshot attached

Environment:Betalabs,test2 and en.wiki

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=72558

Attached:

Screen_Shot_2014-10-24_at_1.48.38_PM.png (634×1 px, 222 KB)

Details

Reference: bz72494

	Subject	Repo	Branch	Lines +/-
	Simplify slug behaviour	VisualEditor/VisualEditor	master	+126 -255

Customize query in gerrit

Related Objects

Mentioned In: rGVED822236c6cad1: Simplify slug behaviour

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:49 AM

• bzimport added projects: VE-deploy-nextup, VisualEditor-EditingTools.

• bzimport set Reference to bz72494.

Ryasmeen created this task.Oct 24 2014, 8:48 PM

Jdforrester-WMF added a project: VisualEditor.Nov 23 2014, 10:48 PM

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Nov 23 2014, 10:59 PM

Jdforrester-WMF removed a project: VE-deploy-nextup.Nov 24 2014, 10:02 PM

Krenair added a project: VisualEditor-ContentEditable.Jan 10 2015, 12:53 AM

Krenair subscribed.

Jdforrester-WMF moved this task from External and Administrivia to Freezer on the VisualEditor board.Jan 15 2015, 12:10 AM

Change 190022 had a related patch set uploaded (by Esanders):
Simplify slug behaviour

https://gerrit.wikimedia.org/r/190022

Patch-For-Review

Change 190022 merged by jenkins-bot:
Simplify slug behaviour

https://gerrit.wikimedia.org/r/190022

Jdforrester-WMF closed this task as Resolved.Feb 24 2015, 1:15 AM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF added a project: WMF-deploy-2015-02-25_(1.25wmf19).

Jdforrester-WMF set Security to None.

Ryasmeen removed a project: Patch-For-Review.Feb 25 2015, 6:58 AM

Jdforrester-WMF mentioned this in rGVED822236c6cad1: Simplify slug behaviour.Mar 3 2015, 7:38 PM

Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Mar 5 2015, 10:45 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:27 PM

Jdforrester-WMF edited a custom field.Mar 29 2015, 11:33 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:49 PM