When editing the infobox in https://fr.wikipedia.org/w/index.php?title=S%C3%A9bastien_Texier&veaction=edit , the heading is misaligned (overlapping with button), see screenshot.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
ProcessDialog: Don't center the title label if there's not enough space | oojs/ui | master | +25 -5 |
Related Objects
Event Timeline
This is the same issue as T70571, where this has been declined (the suggested solution is to make the button labels shorter). The abandoned patch https://gerrit.wikimedia.org/r/160812 would probably still work.
The solution would be not to absolutely center the title if it can't fit.
Before | After |
---|---|
Thanks, Bartosz. The current behavior is clearly undesirable (useless or partially overlapping dialog titles); we may need to do both (shorten some button labels and optimize placement). I defer to @Jdforrester-WMF on the final approach.
Same at the German Wikipedia (check the Saving dialog). The French workaround to this one was changing the equivalent of "Save your changes" to "Contribution"...
A few images to add to this problem (images show Russian):
- save: http://img1.tempfile.ru/14007/217cf59a63/72ca3ef85264e46dc8940df5.png
- review: http://img5.tempfile.ru/14007/21e2c7cd06/db0830133840b484326c1ae5.png
- in templates: http://img1.tempfile.ru/14007/2141f10bfd/81132103a7b84539c4196b6c.png
- when add already used ref: http://tempfile.ru/view/14007/21b40770ca/cd799edc8198704e4665e283.png
"tempfile.ru" is not very reassuring about the lifetime of these links, so let's copy here.
- when add already used ref: http://tempfile.ru/view/14007/21b40770ca/cd799edc8198704e4665e283.png
Change 160812 had a related patch set uploaded (by Bartosz Dziewoński):
ProcessDialog: Don't center the title label if there's not enough space
https://gerrit.wikimedia.org/r/160812
Change 160812 merged by jenkins-bot:
ProcessDialog: Don't center the title label if there's not enough space
https://gerrit.wikimedia.org/r/160812
Worth a User-notice, I think? I believe this improves our UI in several languages significantly. :)
And makes it look worse in others. We'll need to test it post-release to see what further tweaks we need to make VE-side.
Well, no, it doesn't change anything except for the case where the label would be clipped.
Normal label | Long label | |
---|---|---|
Before | ||
After |
The main place people encounter this is where all three labels are very long; this "fix" doesn't actually help them.