Page MenuHomePhabricator
Create Task
Maniphest T89878

mediawiki.feedback should use OOjs UI dialog
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

mediawiki.feedback is used in VisualEditor for submitting comments/suggestions. The dialog for submitting feedback currently uses jQuery UI, which makes it look nonstandard relative to the rest of the UI, non-responsive, and may also be implicated in causing "Escape" to trigger a full exit if no changes have been made.

Details

SubjectRepoBranchLines +/-
Refactoring mw.Feedback to work with OOUI elementsmediawiki/coremaster+504 -299
Customize query in gerrit

Related Objects
Search...

Event Timeline

Eloquence created this task.Feb 18 2015, 8:24 PM
Eloquence raised the priority of this task from to Needs Triage.
Eloquence updated the task description. (Show Details)
Eloquence added a project: VisualEditor.
Eloquence subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2015, 8:24 PM
Eloquence moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Feb 18 2015, 8:24 PM
Jdforrester-WMF triaged this task as Medium priority.Feb 18 2015, 8:25 PM
Jdforrester-WMF added projects: MediaWiki-General, UI-Standardization.
Jdforrester-WMF set Security to None.
Ricordisamoa subscribed.Feb 19 2015, 12:34 PM
Ricordisamoa added a project: OOUI.Feb 19 2015, 2:51 PM
Jdforrester-WMF subscribed.Feb 19 2015, 5:50 PM

This doesn't have anything to do with extending or modifying the OOjs UI library, just using it.

Jdforrester-WMF removed a project: OOUI.Feb 19 2015, 5:50 PM
Ricordisamoa added a subscriber: TheDJ.EditedFeb 19 2015, 6:20 PM
In T89878#1050217, @Jdforrester-WMF wrote:

This doesn't have anything to do with extending or modifying the OOjs UI library, just using it.

@TheDJ tagged T89815 with OOUI, and it doesn't involve extending or modifying the OOjs UI library either.
And why is this tagged VisualEditor, if mediawiki.feedback lives in core (and BTW is also used in UploadWizard)?

Ricordisamoa added a comment.Feb 20 2015, 4:47 PM

You removed OOUI from T89815, but it is still not clear to me why this is tagged VisualEditor.

Jdforrester-WMF added a comment.Feb 20 2015, 4:49 PM
In T89878#1054053, @Ricordisamoa wrote:

You removed OOUI from T89815, but it is still not clear to me why this is tagged VisualEditor.

Because the tool is most noticeably used in VisualEditor, hence the UI clash being more urgent than general backlog.

Jdforrester-WMF added a parent task: T89880: Improvements to mediawiki.feedback (tracking).Feb 23 2015, 6:37 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.
Jdforrester-WMF edited a custom field.Feb 25 2015, 12:00 AM
Jdforrester-WMF assigned this task to Mooeypoo.Feb 25 2015, 1:54 AM
gerritbot subscribed.Feb 25 2015, 2:01 AM

Change 192749 had a related patch set uploaded (by Mooeypoo):
[wip] Refactoring mw.Feedback to work with OOUI elements

https://gerrit.wikimedia.org/r/192749

gerritbot added a project: Patch-For-Review.Feb 25 2015, 2:01 AM
Ricordisamoa awarded a token.Feb 25 2015, 4:29 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.Feb 25 2015, 7:06 PM
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 26 2015, 12:23 AM
Jdforrester-WMF added a project: VisualEditor-Performance.Mar 2 2015, 4:31 PM
Jdforrester-WMF closed this task as Resolved.Mar 3 2015, 6:16 PM
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 3 2015, 6:20 PM
gerritbot added a comment.Mar 3 2015, 6:39 PM

Change 192749 merged by jenkins-bot:
Refactoring mw.Feedback to work with OOUI elements

https://gerrit.wikimedia.org/r/192749

Mooeypoo mentioned this in rMWe75605bc0e0c: Refactoring mw.Feedback to work with OOUI elements.Mar 3 2015, 6:39 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 3 2015, 11:28 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-04_(1.25wmf20); removed Patch-For-Review.Mar 4 2015, 3:14 PM
Jdforrester-WMF added a project: User-notice.Mar 5 2015, 4:32 PM
Jdforrester-WMF moved this task from To Triage to Announce in next Tech/News on the User-notice board.
• gpaumier moved this task from Announce in next Tech/News to Recently announced in Tech/News on the User-notice board.Mar 5 2015, 5:47 PM
• gpaumier moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Mar 12 2015, 3:48 PM
Krinkle moved this task from Backlog to Done on the VisualEditor-Performance board.Mar 19 2015, 10:33 PM
Danny_B moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.May 18 2016, 9:50 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 23 2017, 8:50 AM
Liuxinyu970226 awarded a token.Jun 23 2017, 8:51 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits