Page MenuHomePhabricator
Create Task
Maniphest T90372

Send Parsoid API request immediately when user clicks edit
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Right now, when the user clicks edit, we first load the ViewPageTarget code, then that code sends the Parsoid API request. This means that, on a cold cache, we have to wait for two network requests to complete before we have the HTML and can start setting up the editor. Instead, we should send the API request immediately and load the rest of the VE code in parallel.

Details

SubjectRepoBranchLines +/-
Send Parsoid API request immediately when user clicks editmediawiki/extensions/VisualEditormaster+63 -48
Send Parsoid API request immediately when user clicks editmediawiki/extensions/VisualEditorwmf/1.25wmf21+63 -48
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Feb 22 2015, 6:27 AM
Catrope claimed this task.
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added projects: VisualEditor, VisualEditor-Performance, VisualEditor 2014/15 Q3 blockers.
Catrope added subscribers: Catrope, ori.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2015, 6:27 AM
Catrope set Security to None.Feb 22 2015, 6:28 AM
Catrope edited a custom field.
Krenair subscribed.Feb 22 2015, 4:52 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.Feb 23 2015, 6:17 PM
Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Catrope edited a custom field.Feb 25 2015, 11:10 PM
Catrope moved this task from Backlog to Doing on the VisualEditor-Performance board.Feb 25 2015, 11:13 PM
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 26 2015, 12:28 AM
gerritbot subscribed.Mar 2 2015, 9:12 PM

Change 193026 had a related patch set uploaded (by Jforrester):
[WIP] Factor out loading code into TargetLoader

https://gerrit.wikimedia.org/r/193026

gerritbot added a project: Patch-For-Review.Mar 2 2015, 9:12 PM
Jdforrester-WMF moved this task from Bug Fixes to Blocked on the VisualEditor board.Mar 12 2015, 5:41 PM
gerritbot added a comment.Mar 13 2015, 3:52 PM

Change 196584 had a related patch set uploaded (by Catrope):
Send Parsoid API request immediately when user clicks edit

https://gerrit.wikimedia.org/r/196584

Jdforrester-WMF closed this task as Resolved.Mar 16 2015, 4:08 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-03-18_(1.25wmf22); removed Patch-For-Review.
Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.
gerritbot added a comment.Mar 16 2015, 4:16 PM

Change 196584 merged by jenkins-bot:
Send Parsoid API request immediately when user clicks edit

https://gerrit.wikimedia.org/r/196584

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Mar 16 2015, 4:51 PM
gerritbot added a comment.Mar 17 2015, 9:02 PM

Change 197414 had a related patch set uploaded (by Jforrester):
Send Parsoid API request immediately when user clicks edit

https://gerrit.wikimedia.org/r/197414

gerritbot added a project: Patch-For-Review.Mar 17 2015, 9:02 PM
gerritbot added a comment.Mar 17 2015, 9:04 PM

Change 197414 merged by jenkins-bot:
Send Parsoid API request immediately when user clicks edit

https://gerrit.wikimedia.org/r/197414

ori moved this task from Doing to Done on the VisualEditor-Performance board.Mar 19 2015, 9:48 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 20 2015, 11:32 PM
Jdforrester-WMF mentioned this in rEVEDf620111b9ecf: Send Parsoid API request immediately when user clicks edit.Mar 23 2015, 3:54 PM
Jdforrester-WMF mentioned this in rEVED31a7bd68f4d9: Send Parsoid API request immediately when user clicks edit.
jhsoby mentioned this in T90373: Benchmark hot cache load times.Sep 18 2015, 10:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits