Focusable hIghlight logic is broken, only rendering for the root element
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Eurgh.

See e.g. http://en.wikipedia.beta.wmflabs.org/wiki/Cat?veaction=edit (also reproducible in production). Widely-used template, so we need to fix this.

Details

Subject	Repo	Branch	Lines +/-
Fix webkit column hack	VisualEditor/VisualEditor	wmf/1.25wmf21	+22 -21
Fix webkit column hack	VisualEditor/VisualEditor	wmf/1.25wmf22	+22 -21
Fix webkit column hack	VisualEditor/VisualEditor	master	+22 -21

Customize query in gerrit

Related Objects

Mentioned In: rGVED1fc346395c04: Fix webkit column hack
rGVEDf4cfc903c42d: Fix webkit column hack
rGVED2d14f7acd287: Fix webkit column hack

Event Timeline

Jdforrester-WMF created this task.Mar 20 2015, 2:53 AM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF raised the priority of this task from to High.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: VisualEditor 2014/15 Q3 blockers, VisualEditor, VisualEditor-MediaWiki-Templates.

Jdforrester-WMF subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2015, 2:53 AM

Esanders renamed this task from On enwiki, {{Taxobox}} doesn't get a shield so its contents are clickable to Focusable hIghlight logic is broken, only rendering for the root element..Mar 20 2015, 12:38 PM

Esanders set Security to None.

Change 198216 had a related patch set uploaded (by Esanders):
Fix webkit column hack

https://gerrit.wikimedia.org/r/198216

gerritbot added a project: Patch-For-Review.Mar 20 2015, 12:44 PM

Jdforrester-WMF edited a custom field.Mar 20 2015, 3:55 PM

Change 198216 merged by jenkins-bot:
Fix webkit column hack

https://gerrit.wikimedia.org/r/198216

Change 198278 had a related patch set uploaded (by Jforrester):
Fix webkit column hack

https://gerrit.wikimedia.org/r/198278

Change 198279 had a related patch set uploaded (by Jforrester):
Fix webkit column hack

https://gerrit.wikimedia.org/r/198279

Jdforrester-WMF renamed this task from Focusable hIghlight logic is broken, only rendering for the root element. to Focusable hIghlight logic is broken, only rendering for the root element.Mar 20 2015, 11:05 PM

Jdforrester-WMF closed this task as Resolved.

Jdforrester-WMF edited projects, added WMF-deploy-2015-03-25_(1.25wmf23), WMF-deploy-2015-03-18_(1.25wmf22), WMF-deploy-2015-03-11_(1.25wmf21); removed Patch-For-Review.

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 20 2015, 11:26 PM

Change 198279 merged by jenkins-bot:
Fix webkit column hack

https://gerrit.wikimedia.org/r/198279

Change 198278 merged by jenkins-bot:
Fix webkit column hack

https://gerrit.wikimedia.org/r/198278

Esanders mentioned this in rGVED2d14f7acd287: Fix webkit column hack.Mar 23 2015, 3:53 PM

Jdforrester-WMF mentioned this in rGVEDf4cfc903c42d: Fix webkit column hack.Mar 23 2015, 3:53 PM

Jdforrester-WMF mentioned this in rGVED1fc346395c04: Fix webkit column hack.

Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Mar 26 2015, 9:39 PM

Jdforrester-WMF moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 1 2015, 4:13 PM