Page MenuHomePhabricator
Create Task
Maniphest T94367

Mysterious missingrev failure during save
Closed, ResolvedPublic
Actions

Description

Ori reported that when he was trying to save an article, he repeatedly got errors like {"error":{"code":"missingrev","info":"There is no revision ID 654089716"}. But in reality, his edit was saved, and the revid in the error message was the ID of the new revision he'd created.

It seems like this error is coming from ApiParse.php, probably from the somewhat strange code path that leads to $this->dieUsage( "There is no revision ID {$page->getLatest()}", 'missingrev' );

Details

SubjectRepoBranchLines +/-
Explicitly pass oldid to ApiParse after savingmediawiki/extensions/VisualEditorwmf/1.25wmf24+10 -9
Explicitly pass oldid to ApiParse after savingmediawiki/extensions/VisualEditorwmf/1.26wmf1+10 -9
Explicitly pass oldid to ApiParse after savingmediawiki/extensions/VisualEditormaster+10 -9
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Mar 29 2015, 9:54 PM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added projects: VisualEditor, VisualEditor-MediaWiki.
Catrope subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2015, 9:54 PM
Catrope added a comment.Mar 29 2015, 9:56 PM

Additionally, errors thrown from within a FauxRequest-based API request probably shouldn't kill the main API request.

• MZMcBride subscribed.Apr 2 2015, 12:59 PM
• MZMcBride added a comment.Apr 3 2015, 2:29 AM

https://en.wikipedia.org/w/index.php?title=United_Against_Nuclear_Iran&offset=20150329215213&limit=17&action=history

I'm not sure how prevalent this issue is, but it seems fairly high priority.

Nnemo subscribed.Apr 6 2015, 4:24 PM
Catrope added a comment.Apr 8 2015, 8:02 PM

Probably the same underlying issue as T95466

gerritbot subscribed.Apr 8 2015, 8:24 PM

Change 202911 had a related patch set uploaded (by Catrope):
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202911

gerritbot added a project: Patch-For-Review.Apr 8 2015, 8:24 PM
gerritbot added a comment.Apr 8 2015, 9:02 PM

Change 202911 merged by jenkins-bot:
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202911

Catrope mentioned this in rEVED25c718bc9616: Explicitly pass oldid to ApiParse after saving.Apr 8 2015, 9:03 PM
Jdforrester-WMF assigned this task to Catrope.Apr 8 2015, 9:04 PM
Jdforrester-WMF triaged this task as Unbreak Now! priority.
Jdforrester-WMF added projects: VisualEditor 2014/15 Q4 blockers, WMF-deploy-2015-04-15_(1.26wmf2).
Jdforrester-WMF set Security to None.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Apr 8 2015, 9:12 PM

Change 202920 had a related patch set uploaded (by Catrope):
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202920

gerritbot added a project: Patch-For-Review.Apr 8 2015, 9:12 PM

Change 202921 had a related patch set uploaded (by Catrope):
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202921

Jdforrester-WMF added projects: WMF-deploy-2015-04-01_(1.25wmf24), WMF-deploy-2015-04-08_(1.26wmf1).Apr 8 2015, 10:11 PM
gerritbot added a comment.Apr 8 2015, 10:53 PM

Change 202920 merged by jenkins-bot:
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202920

gerritbot added a comment.Apr 8 2015, 10:53 PM

Change 202921 merged by jenkins-bot:
Explicitly pass oldid to ApiParse after saving

https://gerrit.wikimedia.org/r/202921

Catrope mentioned this in rEVEDdfbd5d278b61: Explicitly pass oldid to ApiParse after saving.Apr 8 2015, 10:53 PM
Catrope mentioned this in rEVED4debb333f4f2: Explicitly pass oldid to ApiParse after saving.
Aklapper added a comment.Apr 14 2015, 5:12 PM

@Catrope: All three patches merged. What's left to do here?

Jdforrester-WMF closed this task as Resolved.Apr 14 2015, 5:53 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
matej_suchanek added a project: User-notice.Apr 17 2015, 12:43 PM
matej_suchanek moved this task from To Triage to In current Tech/News draft on the User-notice board.
• gpaumier moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Apr 20 2015, 4:11 PM
• gpaumier moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Apr 23 2015, 9:47 PM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits