Page MenuHomePhabricator
Create Task
Maniphest T95989

FlaggedRevs edit notices don't render properly in VisualEditor
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Krinkle
Authored By
Sunpriat
Apr 14 2015, 3:25 AM
Tags
Referenced Files
F112738: Снимок33.PNG
Apr 14 2015, 11:51 AM
F112723: Screen_Shot_2015-04-14_at_12.17.13.png
Apr 14 2015, 11:18 AM
F112710: Снимок31.PNG
Apr 14 2015, 10:37 AM
F112711: Снимок32.PNG
Apr 14 2015, 10:37 AM
Subscribers
Aklapper
gerritbot
Krinkle
matmarex
Sunpriat

Description

I try to edit any article in VE in https://ru.wikipedia.org/
and a pop-up window "edit notices" is empty, but there is a text "1 2 3...n notices"

Details

SubjectRepoBranchLines +/-
MWPopupTool: Don't assume editnotice html has a single wrapping elementmediawiki/extensions/VisualEditorwmf/1.25wmf24+6 -6
MWPopupTool: Don't assume editnotice html has a single wrapping elementmediawiki/extensions/VisualEditorwmf/1.26wmf1+6 -6
MWPopupTool: Don't assume editnotice html has a single wrapping elementmediawiki/extensions/VisualEditormaster+6 -6
Customize query in gerrit

Related Objects

Event Timeline

Sunpriat created this task.Apr 14 2015, 3:25 AM
Sunpriat raised the priority of this task from to Needs Triage.
Sunpriat updated the task description. (Show Details)
Sunpriat added a project: VisualEditor.
Sunpriat subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2015, 3:25 AM
Aklapper added a comment.Apr 14 2015, 10:23 AM

Thanks for taking the time to report this!
Could you please provide a specific example link to reproduce, and the steps how to trigger such a popup window?

Sunpriat added a comment.EditedApr 14 2015, 10:37 AM

any browser, any article, any wiki

Снимок31.PNG (193×586 px, 9 KB)

https://en.wikipedia.org/wiki/Mulan_II?veaction=edit
Снимок32.PNG (302×663 px, 20 KB)

https://ru.wikipedia.org/wiki/%D0%9C%D1%83%D0%BB%D0%B0%D0%BD_2?veaction=edit

Krinkle subscribed.EditedApr 14 2015, 11:18 AM

Not all pages are affected. I can reproduce the issue on those two pages, but the majority of other pages are unaffected.

These pages have in common that they're protected with FlaggedRevs. Compare to the wikitext editor:

Screen_Shot_2015-04-14_at_12.17.13.png (236×1 px, 34 KB)

{"visualeditor":{"result":"success","notices":{"revreview-locked":
<b>Note:</b>
Edits to this page are subject to review (<a href="/wiki/Wikipedia:Pending_changes" title="Wikipedia:Pending changes">help</a>).
<div id="mw-fr-logexcerpt"><ul> .. </ul> </div>

Only the first node (the bold word) shows up in VisualEditor.

Снимок31.PNG (193×586 px, 9 KB)

Krinkle renamed this task from VE: in ru.wiki does not show the edit notices to FlaggedRevs edit notices don't render properly in VisualEditor.Apr 14 2015, 11:23 AM
Krinkle claimed this task.
Krinkle added a project: VisualEditor-MediaWiki.
Krinkle set Security to None.
gerritbot subscribed.Apr 14 2015, 11:25 AM

Change 204038 had a related patch set uploaded (by Krinkle):
MWPopupTool: Don't assume editnotice html has a single wrapping element

https://gerrit.wikimedia.org/r/204038

gerritbot added a project: Patch-For-Review.Apr 14 2015, 11:25 AM
Sunpriat added a comment.EditedApr 14 2015, 11:51 AM

random page:
https://ru.wikipedia.org/wiki/%D0%9A%D1%80%D0%BD%D0%B0%D1%87?veaction=edit

Снимок33.PNG (320×645 px, 20 KB)

no FlaggedRevs protect

Krinkle added a comment.Apr 14 2015, 12:21 PM
In T95989#1206273, @Sunpriat wrote:

random page:
https://ru.wikipedia.org/wiki/%D0%9A%D1%80%D0%BD%D0%B0%D1%87?veaction=edit

Снимок33.PNG (320×645 px, 20 KB)

no FlaggedRevs protect

That is a separate issue. The problem there is that ru.wikipedia.org has a global edit notice at MediaWiki:Editnotice-0 but is invisible to most users (only visible to sysops). See also T91715. I've converted it to use MediaWiki:Editnotice-notext. Fixed!

matmarex subscribed.Apr 14 2015, 3:05 PM

Same issue as T95822?

gerritbot added a comment.Apr 14 2015, 3:15 PM

Change 204038 merged by jenkins-bot:
MWPopupTool: Don't assume editnotice html has a single wrapping element

https://gerrit.wikimedia.org/r/204038

Krinkle mentioned this in rEVED66c9d538c504: MWPopupTool: Don't assume editnotice html has a single wrapping element.Apr 14 2015, 3:15 PM
Krinkle added a comment.Apr 14 2015, 3:17 PM
In T95989#1206646, @matmarex wrote:

Same issue as T95822?

Since those don't show anything at all, it's likely not the FlaggedRevs issue but the Editnotice-notext issue. Which is discussed at T91715 and T45013. Though doesn't have a proper task yet. Let's use T95822 for that.

Jdforrester-WMF closed this task as Resolved.Apr 14 2015, 3:41 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF edited projects, added OOUI, OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF raised the priority of this task from Medium to High.Apr 14 2015, 5:53 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
gerritbot added a comment.Apr 14 2015, 10:14 PM

Change 204167 had a related patch set uploaded (by Catrope):
MWPopupTool: Don't assume editnotice html has a single wrapping element

https://gerrit.wikimedia.org/r/204167

gerritbot added a project: Patch-For-Review.Apr 14 2015, 10:14 PM

Change 204168 had a related patch set uploaded (by Catrope):
MWPopupTool: Don't assume editnotice html has a single wrapping element

https://gerrit.wikimedia.org/r/204168

gerritbot added a comment.Apr 14 2015, 10:52 PM

Change 204167 merged by jenkins-bot:
MWPopupTool: Don't assume editnotice html has a single wrapping element

https://gerrit.wikimedia.org/r/204167

Catrope mentioned this in rEVEDd7f851ba063a: MWPopupTool: Don't assume editnotice html has a single wrapping element.Apr 14 2015, 10:53 PM
gerritbot added a comment.Apr 14 2015, 11:01 PM

Change 204168 merged by jenkins-bot:
MWPopupTool: Don't assume editnotice html has a single wrapping element

https://gerrit.wikimedia.org/r/204168

Catrope mentioned this in rEVED668a7c1aace5: MWPopupTool: Don't assume editnotice html has a single wrapping element.Apr 14 2015, 11:01 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-04-15_(1.26wmf2), WMF-deploy-2015-04-08_(1.26wmf1), WMF-deploy-2015-04-01_(1.25wmf24); removed Patch-For-Review, OOjs-UI-next-release.Apr 14 2015, 11:47 PM
matej_suchanek added a project: User-notice.Apr 17 2015, 12:43 PM
matej_suchanek moved this task from To Triage to In current Tech/News draft on the User-notice board.
nshahquinn-wmf moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 17 2015, 7:39 PM
• gpaumier moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Apr 20 2015, 4:11 PM
• gpaumier moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Apr 23 2015, 9:47 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Apr 29 2015, 9:35 PM
Sunpriat mentioned this in T97644: VE: empty "edit notices".Apr 30 2015, 1:49 PM
Sunpriat mentioned this in T95822: Assist de/it/pl/pt/ru-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice".May 1 2015, 6:41 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits