Page MenuHomePhabricator
Create Task
Maniphest T97838

[Regression?] Removing edited articles from watchlist at it.wp
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Pick an article, add it to your watchlist, now edit it, try to save:
notice the Watch this page box is unchecked, and as a matter of fact the star isn't blue anymore.
Can't reproduce at en.wp.

Details

SubjectRepoBranchLines +/-
mw.Target: Fix API breakage of watchlist preference checkmediawiki/extensions/VisualEditorwmf/1.26wmf5+1 -1
mw.Target: Fix API breakage of watchlist preference checkmediawiki/extensions/VisualEditorwmf/1.26wmf4+1 -1
mw.Target: Fix API breakage of watchlist preference checkmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Elitre created this task.May 1 2015, 7:23 PM
• Elitre raised the priority of this task from to High.
• Elitre updated the task description. (Show Details)
• Elitre added a project: VisualEditor.
• Elitre subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2015, 7:23 PM
• Elitre added a project: acl*sre-team.May 1 2015, 7:27 PM
• Elitre added a subscriber: ori.

Actually, adding @ori. Maybe this has to do with JavaScript "experiments" at it.wiki?

• Elitre added a subscriber: Nemo_bis.May 1 2015, 7:28 PM
Catrope merged a task: T97851: When saving an edit with VisualEditor, the "Watch page" checkbox is disabled even though the page is already on the watchlist.May 1 2015, 8:48 PM
Catrope added a subscriber: pajz.
Catrope subscribed.
In T97838#1253167, @Elitre wrote:

Actually, adding @ori. Maybe this has to do with JavaScript "experiments" at it.wiki?

Well it's apparently also happening on dewiki...

Mannivu subscribed.May 1 2015, 11:35 PM
Dzahn removed a project: acl*sre-team.May 2 2015, 12:59 AM
Dzahn set Security to None.
Nnemo subscribed.May 3 2015, 8:53 PM
Nnemo added a comment.May 4 2015, 10:32 PM

Apparently, I just encountered this bug in the visual editor on fr.wikipedia.org.

Josve05a subscribed.EditedMay 4 2015, 10:44 PM

I could reproduce it on frwp and on https://en.wikipedia.org/wiki/Martyn_Thomas_(rugby_player) with ?setlang=fr
and I could reproduce it on https://en.wikipedia.org/wiki/Harry_G._Shaffer after turning back, so that didn't seem to be the issue.

So I can confirm on enwp and frwp in Chrome.

Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor 2014/15 Q4 blockers.May 6 2015, 1:00 AM
Jdforrester-WMF moved this task from Nominated to Backlog: Urgent Fixes on the VisualEditor 2014/15 Q4 blockers board.May 6 2015, 6:28 PM
Jdforrester-WMF edited a custom field.May 6 2015, 8:16 PM
TheDJ subscribed.May 7 2015, 11:21 AM

ehm, perhaps another case of inverted booleans due to last weeks api changes ?

Krenair subscribed.May 7 2015, 2:46 PM
This comment was removed by Krenair.
Krenair claimed this task.May 7 2015, 3:00 PM
gerritbot subscribed.May 7 2015, 3:37 PM

Change 209504 had a related patch set uploaded (by Jforrester):
mw.Target: Fix API breakage of watchlist preference check

https://gerrit.wikimedia.org/r/209504

gerritbot added a project: Patch-For-Review.May 7 2015, 3:37 PM
Jdforrester-WMF moved this task from Backlog: Urgent Fixes to Doing on the VisualEditor 2014/15 Q4 blockers board.May 7 2015, 3:44 PM
gerritbot added a comment.May 7 2015, 11:27 PM

Change 209657 had a related patch set uploaded (by Jforrester):
mw.Target: Fix API breakage of watchlist preference check

https://gerrit.wikimedia.org/r/209657

gerritbot added a comment.May 7 2015, 11:27 PM

Change 209658 had a related patch set uploaded (by Jforrester):
mw.Target: Fix API breakage of watchlist preference check

https://gerrit.wikimedia.org/r/209658

gerritbot added a comment.May 7 2015, 11:29 PM

Change 209504 merged by jenkins-bot:
mw.Target: Fix API breakage of watchlist preference check

https://gerrit.wikimedia.org/r/209504

Jdforrester-WMF mentioned this in rEVED6c86046bd875: mw.Target: Fix API breakage of watchlist preference check.May 7 2015, 11:29 PM
gerritbot added a comment.May 7 2015, 11:32 PM

Change 209658 merged by jenkins-bot:
mw.Target: Fix API breakage of watchlist preference check

https://gerrit.wikimedia.org/r/209658

gerritbot added a comment.May 7 2015, 11:32 PM

Change 209657 merged by jenkins-bot:
mw.Target: Fix API breakage of watchlist preference check

https://gerrit.wikimedia.org/r/209657

Jdforrester-WMF mentioned this in rEVED82ff8e72498e: mw.Target: Fix API breakage of watchlist preference check.May 7 2015, 11:33 PM
Jdforrester-WMF mentioned this in rEVEDe859342f8b8b: mw.Target: Fix API breakage of watchlist preference check.
Jdforrester-WMF closed this task as Resolved.May 7 2015, 11:53 PM
Jdforrester-WMF added projects: WMF-deploy-2015-04-29_(1.26wmf4), WMF-deploy-2015-05-06_(1.26wmf5), WMF-deploy-2015-05-13_(1.26wmf6).
Jdforrester-WMF added a project: User-notice.
Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.
• gpaumier moved this task from To Triage to Announce in next Tech/News on the User-notice board.May 8 2015, 4:44 PM
Jdforrester-WMF removed a project: Patch-For-Review.May 8 2015, 10:27 PM
• gpaumier moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.May 9 2015, 2:54 AM
• gpaumier moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.May 9 2015, 3:07 AM
• gpaumier moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.May 14 2015, 10:49 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Aug 5 2015, 1:42 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits