r99632 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99631‎ | r99632 | r99633 >
Date:14:13, 12 October 2011
Author:bawolff
Status:ok
Tags:
Comment:
(bug 31637) Do not extract tiff:Orientation from XMP data, since then it will be used to rotate images, which is kind of unexpected.

Most people only really expect the Exif data to be used for rotating images (if that), so its unexpected when the xmp property causes an image to be rotated. So disable extracting that property from XMP.
Modified paths:
  • /trunk/phase3/includes/media/XMPInfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/XMPInfo.php
@@ -557,13 +557,16 @@
558558 'map_group' => 'exif',
559559 'mode' => XMPReader::MODE_SIMPLE,
560560 ),
561 - 'Orientation' => array(
562 - 'map_group' => 'exif',
563 - 'mode' => XMPReader::MODE_SIMPLE,
564 - 'validate' => 'validateClosed',
565 - 'choices' => array( '1' => true, '2' => true, '3' => true, '4' => true, 5 => true,
566 - '6' => true, '7' => true, '8' => true ),
567 - ),
 561+ /**** Do not extract this property
 562+ * It interferes with auto exif rotation.
 563+ * 'Orientation' => array(
 564+ * 'map_group' => 'exif',
 565+ * 'mode' => XMPReader::MODE_SIMPLE,
 566+ * 'validate' => 'validateClosed',
 567+ * 'choices' => array( '1' => true, '2' => true, '3' => true, '4' => true, 5 => true,
 568+ * '6' => true, '7' => true, '8' => true ),
 569+ *),
 570+ ******/
568571 'PhotometricInterpretation' => array(
569572 'map_group' => 'exif',
570573 'mode' => XMPReader::MODE_SIMPLE,

Follow-up revisions

RevisionCommit summaryAuthorDate
r100840REL1_18: MFT r98426, r99371, r99632, r99897, r99910, r99914, r999952reedy18:47, 26 October 2011
r1011261.18wmf1: MFT r98669, r99164, r99321, r99332, r99632, r99897, r99914, r99952,...catrope12:09, 28 October 2011

Status & tagging log