Closed Bug 1776426 Opened 3 years ago Closed 3 months ago

Remove InstallTrigger implementation

Categories

(Toolkit :: Add-ons Manager, task, P3)

task

Tracking

()

RESOLVED FIXED
144 Branch
Tracking Status
firefox144 --- fixed

People

(Reporter: rpl, Assigned: gregp)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

As a follow up to Bug 1772901, once the InstallTrigger implementation has been disabled in all channels for enough baking time and we are sure we will not have to flip the "extensions.InstallTriggerImpl.enabled" pref back to true as a last resort, we'll want to completely remove it from mozilla-cental, in particular:

  • remove amInstallTrigger.jsm
  • remove InstallTrigger related code from dom/base/nsGlobalWindowInner.cpp (but keep the part of nsGlobalWindowInner::GetInstallTrigger that would still be needed to keep the global InstallTrigger enumerable and set to null if we have not yep disabled it on all channels)
  • remove the "extensions.InstallTriggerImpl.enabled" pref and code that is referencing it
  • remove tests covering the behaviors expected by the InstallTrigger implementation itself
Severity: -- → N/A
Priority: -- → P2
See Also: → 1775404
Priority: P2 → P3
See Also: → 1950440

These tests are removed:

  • browser/base/content/test/webextensions/browser_permissions_installTrigger.js
  • dom/base/crashtests/642022-1.html
  • js/xpconnect/crashtests/290162-1.html
  • js/xpconnect/crashtests/616930-1.html
  • js/xpconnect/crashtests/648206-1.html
  • js/xpconnect/tests/mochitest/test_bug628410.html
  • toolkit/mozapps/extensions/test/browser/browser_installtrigger_install.js
  • toolkit/mozapps/extensions/test/xpcshell/test_installtrigger_schemes.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_amosigned_trigger.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_amosigned_trigger_iframe.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_auth.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_auth2.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_auth3.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_badargs.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_badargs2.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_badhash.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_badhashtype.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_bug540558.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_bug611242.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_bug638292.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_bug645699.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_bug645699_postDownload.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_bug672485.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_containers.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_cookies.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_cookies2.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_cookies3.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_cookies4.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_enabled.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_hash.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_hash2.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_httphash.js

These test the X-Target-Digest header, which was introduced in bug 591070. I did some debugging and it seems this header is completely ignored in extension installation from navigation. I guess because the content handler doesn't see redirects?

  • toolkit/mozapps/extensions/test/xpinstall/browser_httphash2.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_httphash3.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_httphash4.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_httphash5.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_httphash6.js

  • toolkit/mozapps/extensions/test/xpinstall/browser_installchrome.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_localfile2.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_localfile4.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_localfile4_postDownload.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_privatebrowsing.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_relative.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_softwareupdate.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_trigger_redirect.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_trigger.js

Navigation installation in iframes is covered by toolkit/mozapps/extensions/test/browser/browser_subframe_install.js

  • toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_trigger_iframe.js
  • toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_trigger_xorigin.js

  • toolkit/mozapps/extensions/test/xpinstall/bug540558.html

  • toolkit/mozapps/extensions/test/xpinstall/bug638292.html

  • toolkit/mozapps/extensions/test/xpinstall/bug645699.html

  • toolkit/mozapps/extensions/test/xpinstall/startsoftwareupdate.html

  • toolkit/mozapps/extensions/test/xpinstall/triggerredirect.html

    These tests are modified to test navigation-based installation

  • browser/base/content/test/webextensions/browser_permissions_unsigned.js

  • browser/components/enterprisepolicies/tests/browser/browser_policy_extensionsettings.js

  • browser/components/enterprisepolicies/tests/browser/extensionsettings.html

  • toolkit/mozapps/extensions/test/xpinstall/browser_auth4.js

  • toolkit/mozapps/extensions/test/xpinstall/browser_corrupt.js

  • toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js

  • toolkit/mozapps/extensions/test/xpinstall/browser_empty.js

  • toolkit/mozapps/extensions/test/xpinstall/browser_newwindow.js

  • toolkit/mozapps/extensions/test/xpinstall/browser_offline.js

Assignee: nobody → gregp
Attachment #9500514 - Attachment description: WIP: Bug 1776426 - Remove InstallTrigger implementation → Bug 1776426 - Remove InstallTrigger implementation
Status: NEW → ASSIGNED

These prefs are removed:

  • extensions.InstallTriggerImpl.enabled
Blocks: old-prefs
Depends on: 1979227
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
See Also: → 1986984
QA Whiteboard: [qa-triage-done-c145/b144]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: