feat: Icon builder to library #8203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
May 9, 2025
| "@babel/types": "7.24.0", | ||
| "@parcel/transformer-react-refresh-wrap": "2.14.0", | ||
| "@parcel/transformer-js": "2.14.0", | ||
| "@parcel/codeframe": "2.14.0", |
Member
Author
There was a problem hiding this comment.
we wind up with duplicates for some reason, it's the weirdest thing, even though 2.14 fulfills ^2.13.1... yarn decides it should be 2.15.1. So I locked down the ones I found to be getting strange duplicates
├─ @parcel/config-default@npm:2.14.0 [8657b]
│ └─ @parcel/transformer-js@npm:2.14.0 [ef688] (via npm:2.14.0 [ef688])
│
├─ @parcel/config-storybook@npm:0.0.2
│ └─ @parcel/transformer-js@npm:2.15.1 [144cf] (via npm:^2.13.1 [144cf])
| name({bundle}) { | ||
| let mainAsset = bundle.getMainEntry(); | ||
|
|
||
| if (!mainAsset?.filePath.includes('react-spectrum/packages')) { |
Member
There was a problem hiding this comment.
This is the same logic as below? Could the if conditions be merged?
Member
Author
There was a problem hiding this comment.
yeah, so open question about this due to ask for non-20 sized icons
I had it originally separate though as a reminder to see if there was a better condition we could use
| @@ -0,0 +1,42 @@ | |||
| # Parcel example | |||
devongovett
approved these changes
Jun 3, 2025
yihuiliao
approved these changes
Jun 3, 2025
LFDanLu
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Adds an option to our icon builder so that users can build a library of icons more easily with the same processing we apply to our own S2 Icon library.
To run the new option, create a new npm project with an appropriate package.json, such as
Copy your svg icons into a
srcdirectory in the project.Then run
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the last commit with a comment on it, check out the new artifact S2 Custom Icons
There should be an action button with an AlignRight icon in it.
🧢 Your Project: