Skip to content

fix: TreeView inadvertent focus trap #8277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snowystinger merged 6 commits into from
Jun 3, 2025
Merged

fix: TreeView inadvertent focus trap #8277

snowystinger merged 6 commits into from
Jun 3, 2025

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented May 21, 2025

Closes #8111

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented May 21, 2025

Build successful! 🎉

devongovett
devongovett reviewed May 23, 2025
View reviewed changes
@LFDanLu
Copy link
Member

LFDanLu commented May 30, 2025

lets get this tested on Monday, added it to the sheet

@rspbot
Copy link

rspbot commented Jun 2, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 2, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 3, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 3, 2025

Build successful! 🎉

@snowystinger snowystinger enabled auto-merge June 3, 2025 22:03
@snowystinger snowystinger added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit db1b174 Jun 3, 2025
30 checks passed
@snowystinger snowystinger deleted the snowystinger-patch-1 branch June 3, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

S2 TreeView traps focus in expand/collapse button when no focusable content

5 participants

@snowystinger @rspbot @LFDanLu @devongovett