Updated screenshots/animated gif; PR feedback

Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/signinsignup/SignInSignUp.kt

@@ -60,7 +60,6 @@ import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.example.compose.jetsurvey.R
 import com.example.compose.jetsurvey.theme.JetsurveyTheme
-import com.example.compose.jetsurvey.theme.outlinedTextFieldColors
 import com.example.compose.jetsurvey.theme.stronglyDeemphasizedAlpha
 
 @Composable
@@ -159,7 +158,6 @@ fun Email(
                 onImeAction()
             }
         ),
-        colors = outlinedTextFieldColors(),
     )
 
     emailState.getError()?.let { error -> TextFieldError(textError = error) }
@@ -228,7 +226,6 @@ fun Password(
                 onImeAction()
             }
         ),
-        colors = outlinedTextFieldColors()
     )
 
     passwordState.getError()?.let { error -> TextFieldError(textError = error) }

Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/signinsignup/WelcomeScreen.kt

@@ -122,8 +122,9 @@ private fun Branding(modifier: Modifier = Modifier) {
 @Composable
 private fun Logo(
     modifier: Modifier = Modifier,
+    lightTheme: Boolean = LocalContentColor.current.luminance() < 0.5f,
 ) {
-    val assetId = if (LocalContentColor.current.luminance() < 0.5f) {
+    val assetId = if (lightTheme) {
         R.drawable.ic_logo_light
     } else {
         R.drawable.ic_logo_dark

Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/survey/SurveyQuestions.kt

@@ -704,8 +704,9 @@ private fun DateQuestion(
 @Composable
 private fun PhotoDefaultImage(
     modifier: Modifier = Modifier,
+    lightTheme: Boolean = LocalContentColor.current.luminance() < 0.5f,
 ) {
-    val assetId = if (LocalContentColor.current.luminance() < 0.5f) {
+    val assetId = if (lightTheme) {
         R.drawable.ic_selfie_light
     } else {
         R.drawable.ic_selfie_dark

Jetsurvey/app/src/main/java/com/example/compose/jetsurvey/theme/Theme.kt

@@ -17,10 +17,7 @@
 package com.example.compose.jetsurvey.theme
 
 import androidx.compose.foundation.isSystemInDarkTheme
-import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.material3.MaterialTheme
-import androidx.compose.material3.TextFieldColors
-import androidx.compose.material3.TextFieldDefaults
 import androidx.compose.material3.darkColorScheme
 import androidx.compose.material3.lightColorScheme
 import androidx.compose.runtime.Composable
@@ -90,20 +87,6 @@ private val DarkColors = darkColorScheme(
     surfaceTint = md_theme_dark_surfaceTint,
 )
 
-@OptIn(ExperimentalMaterial3Api::class) // outlinedTextFieldColors is experimental in m3
-@Composable
-fun outlinedTextFieldColors(): TextFieldColors =
-    TextFieldDefaults.outlinedTextFieldColors(
-        unfocusedLabelColor = MaterialTheme.colorScheme.onSurface
-            .copy(alpha = stronglyDeemphasizedAlpha),
-        unfocusedBorderColor = MaterialTheme.colorScheme.onSurface
-            .copy(alpha = 0.38f),
-        focusedTrailingIconColor = MaterialTheme.colorScheme.onSurface
-            .copy(alpha = stronglyDeemphasizedAlpha),
-        unfocusedTrailingIconColor = MaterialTheme.colorScheme.onSurface
-            .copy(alpha = stronglyDeemphasizedAlpha),
-    )
-
 @Composable
 fun JetsurveyTheme(
     useDarkTheme: Boolean = isSystemInDarkTheme(),
@@ -120,9 +103,7 @@ fun JetsurveyTheme(
         systemUiController.setSystemBarsColor(
             color = colors.surface,
             darkIcons = !useDarkTheme
-        ) {
-            md_theme_dark_surface
-        }
+        )
 
         onDispose { }
     }