Skip to content

Update SettingsViewModel.kt #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yannigoyal wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update SettingsViewModel.kt #1897

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9efe95d
Update SettingsViewModel.kt
yannigoyal Apr 23, 2025
7d6c98e
Update SettingsViewModel.kt
yannigoyal Apr 23, 2025
0ae715a
Update SettingsViewModel.kt
yannigoyal Apr 23, 2025
7c9c983
Update SettingsViewModel.kt
yannigoyal Apr 24, 2025
8bacb1c
Update SettingsViewModel.kt
yannigoyal Jul 11, 2025
bc1007d
indent
yannigoyal Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update SettingsViewModel.kt 
updated for just commit
  • Loading branch information
@yannigoyal
yannigoyal committed Jul 11, 2025
commit 8bacb1c3aa5e975ca6ef292f84a3a50b3c7d44e1
1 change: 1 addition & 0 deletions ...rc/main/kotlin/com/google/samples/apps/nowinandroid/feature/settings/SettingsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ class SettingsViewModel @Inject constructor(
DARK -> AppCompatDelegate.MODE_NIGHT_YES
}
AppCompatDelegate.setDefaultNightMode(splashMode)

if (Build.VERSION.SDK_INT >= VERSION_CODES.S) {
val uiModeMode = when (darkThemeConfig) {
Copy link
Contributor

@SimonMarquis SimonMarquis Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uiModeMode should be renamed, why not simply uiMode or nightMode?

FOLLOW_SYSTEM -> UiModeManager.MODE_NIGHT_AUTO
Expand Down