Add support for search occurrences count and search navigation #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srtvprateek
approved these changes
Feb 22, 2025
Member
|
@kpchandora thanks for the contribution, Can we also add a different highlight color for the currently focused occurrence? This'll improve the readability. |
Contributor
Author
|
@srtvprateek Sure, I will add that as well. |
srtvprateek
pushed a commit
that referenced
this pull request
Mar 2, 2025
* Add support for search occurrences count and search navigation * Separate out search logic * Update normalise method to use correct replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #337