Skip to content

Conversation

@zhaoyunxing92
Copy link
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.


/**
* The algorithm to use for selecting which files to compile.
* The algorithm to use for selecting which files to compile. The default values are implemented in `incrementalCompilationConfiguration()`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reader of this documentation cannot access easily the incrementalCompilationConfiguration() source code. I think that it is better to not add this reference.

@desruisseaux desruisseaux self-assigned this Sep 13, 2025
@desruisseaux desruisseaux added the enhancement New feature or request label Sep 13, 2025
@desruisseaux desruisseaux added this to the 4.0.0-beta-3 milestone Sep 13, 2025
@desruisseaux
Copy link
Contributor

It looks fine to me, with only a suggestion to remove the reference to incrementalCompilationConfiguration() package-private method in the documentation.

@desruisseaux desruisseaux merged commit be18137 into apache:master Sep 18, 2025
26 checks passed
@desruisseaux desruisseaux changed the title Supoort command line paramenters and some optimizations Suport command line parameters for incremental build Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants