improve MAPIMessage.guess7BitEncoding, improve MAPIMessage.getHtmlBody #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
pjfanning
reviewed
May 23, 2019
Member
pjfanning
left a comment
There was a problem hiding this comment.
Do you have any sample files to try the new code on? If so, can you use them in unit tests (for regression purposes)?
- general properties code page sources: PR_MESSAGE_CODEPAGE, default ANSI code page of PR_MESSAGE_LOCALE_ID, charset from content-type header - code page source for PR_BODY and PR_BODY_HTML: PR_INTERNET_CPID (as documented) no need to get from HTML; Outlook skips that too special case: outlook uses code page CP1252 instead of utf-8 for PR_BODY * improve MAPIMessage.getHtmlBody: - in case if binary property use code page defined in PR_INTERNET_CPID, default to CP1252 (no need to get from HTML; Outlook skips that too) - in case of string property rely on code page set by MAPIMessage.guess7BitEncoding * add unit tests
Author
|
I have added a unit test to the PR. |
Member
|
Closed using 721180d |
asfgit
pushed a commit
that referenced
this pull request
Oct 6, 2019
…ge.getHtmlBody. Thanks to Dominik Hölzl. This closes #149 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860043 13f79535-47bb-0310-9956-ffa450edef68
Alain-Bearez
pushed a commit
to cuali/poi
that referenced
this pull request
Dec 12, 2019
…ge.getHtmlBody. Thanks to Dominik Hölzl. This closes apache#149 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860043 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve MAPIMessage.guess7BitEncoding
no need to get from HTML; Outlook skips that too
special case: outlook uses code page CP1252 instead of utf-8 for PR_BODY
improve MAPIMessage.getHtmlBody: