Skip to content

add null checker to sourceRow so it can be skipped if it's null #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xjlin0 wants to merge 3 commits into from
Closed

add null checker to sourceRow so it can be skipped if it's null #177

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6ae7ec
add null checker to sourceRow so it can be skipped if it's null
xjlin0 Apr 23, 2020
982ec95
make it continue for the next row
xjlin0 Apr 24, 2020
e0474ff
use precheck before for loop
xjlin0 Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add null checker to sourceRow so it can be skipped if it's null
  • Loading branch information
@xjlin0
xjlin0 committed Apr 23, 2020
commit e6ae7ec9222b91e0b3527f7085a8e56c04b95512
32 changes: 17 additions & 15 deletions src/java/org/apache/poi/ss/usermodel/RangeCopier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,24 @@ private void copyRange(CellRangeAddress sourceRange, int deltaX, int deltaY, She

for(int rowNo = sourceRange.getFirstRow(); rowNo <= sourceRange.getLastRow(); rowNo++) {
Row sourceRow = sourceClone.getRow(rowNo); // copy from source copy, original source might be overridden in process!
for (int columnIndex = sourceRange.getFirstColumn(); columnIndex <= sourceRange.getLastColumn(); columnIndex++) {
Cell sourceCell = sourceRow.getCell(columnIndex);
if(sourceCell == null)
continue;
Row destRow = destSheet.getRow(rowNo + deltaY);
if(destRow == null)
destRow = destSheet.createRow(rowNo + deltaY);

Cell newCell = destRow.getCell(columnIndex + deltaX);
if(newCell == null) {
newCell = destRow.createCell(columnIndex + deltaX);
}
if (sourceRow != null) {
for (int columnIndex = sourceRange.getFirstColumn(); columnIndex <= sourceRange.getLastColumn(); columnIndex++) {
Cell sourceCell = sourceRow.getCell(columnIndex);
if (sourceCell == null)
continue;
Row destRow = destSheet.getRow(rowNo + deltaY);
if (destRow == null)
destRow = destSheet.createRow(rowNo + deltaY);

Cell newCell = destRow.getCell(columnIndex + deltaX);
if (newCell == null) {
newCell = destRow.createCell(columnIndex + deltaX);
}

cloneCellContent(sourceCell, newCell, null);
if(newCell.getCellType() == CellType.FORMULA)
adjustCellReferencesInsideFormula(newCell, destSheet, deltaX, deltaY);
cloneCellContent(sourceCell, newCell, null);
if (newCell.getCellType() == CellType.FORMULA)
adjustCellReferencesInsideFormula(newCell, destSheet, deltaX, deltaY);
}
}
}
}
Expand Down