Skip to content

Conversation

@komarovd95
Copy link

Implementation of POLYLINE geometry using LineTo path segments.

The code itself runs in production for a relatively long time and tested multiple times. I also used this file to test its working.

@pjfanning
Copy link
Member

Can I ask you to test with Java 8. Neither this nor your previous PR compile with Java 8.

Issues like

/Users/pj.fanning/svn/poi/poi-ooxml/src/test/java/org/apache/poi/xdgf/usermodel/section/geometry/TestPolylineTo.java:100: error: cannot infer type arguments for java.util.HashMap<K,V>
                new HashMap<>() {{

I will fix this locally so you don't need to fix it here - but if you submit more PRs, can you ensure that they compile?

@asfgit asfgit closed this in d0a5b62 Mar 6, 2024
@komarovd95
Copy link
Author

Can I ask you to test with Java 8. Neither this nor your previous PR compile with Java 8.

Issues like

/Users/pj.fanning/svn/poi/poi-ooxml/src/test/java/org/apache/poi/xdgf/usermodel/section/geometry/TestPolylineTo.java:100: error: cannot infer type arguments for java.util.HashMap<K,V>
                new HashMap<>() {{

I will fix this locally so you don't need to fix it here - but if you submit more PRs, can you ensure that they compile?

Sorry, my fault. I'll definitely check it next time

alexjansons pushed a commit to alexjansons/poi that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants