Skip to content

Conversation

@shendongsd
Copy link

No description provided.

@caigy
Copy link
Contributor

caigy commented Aug 24, 2021

@shendongsd Is there an issue related to this PR? Would you also support preferredDuringSchedulingIgnoredDuringExecution, or why not?

@shendongsd
Copy link
Author

@shendongsd Is there an issue related to this PR? Would you also support preferredDuringSchedulingIgnoredDuringExecution, or why not?
the issues/38 is related to this PR,i will also support preferredDuringSchedulingIgnoredDuringExecution and improve and perfect this PR

@shendongsd shendongsd changed the title Add nodeAffinity for nameService pod [ISSUE 38] Add nodeAffinity for nameService pod Aug 28, 2021
Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think abbreviations like reqDurSchIgnDurExe are not no clear, especially for new beginners of K8s. For example, 'req' is short for 'request' in most cases other than 'require'. I think it more clear to leave the full names defined in K8s.
  2. Could you provide the reason to remove go.mod? I don't think this deletion is related to the issue.

@shendongsd
Copy link
Author

  1. I think abbreviations like reqDurSchIgnDurExe are not no clear, especially for new beginners of K8s. For example, 'req' is short for 'request' in most cases other than 'require'. I think it more clear to leave the full names defined in K8s.
  2. Could you provide the reason to remove go.mod? I don't think this deletion is related to the issue.

1、I changed the variable name and restored "go.mod"

@AdheipSingh
Copy link

the user should be able to just mention the nodeAffinity in the CR, templating out each and every spec in the nodeAffinity, isn't a best practice in the operator.

nodeAffinity:
   ----
   ----

this is only needed in the CR.

@shendongsd shendongsd closed this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants