Skip to content

Conversation

@waterlx
Copy link

@waterlx waterlx commented Dec 11, 2025

What changes were proposed in this pull request?

  1. Add partitions related events, for the following external catalog operations: create / drop / alter / rename. A base "PartitionsEvent" is added by extending "TableEvent". One "PartitionsEvent" (and its subs) could contain the operation for one or more partitions. So it is named as "PartitionsEvent" (in the plural form of partition), so are its subs.

  2. Post those events in the corresponding external catalog operations

Why are the changes needed?

The operation list extracted from Spark events are of great help for user to summarize what have been done against a db/table/function/partition, for the purpose of logging and/or auditing.
In ExternalCatalogWithListener, there are events posted against db, table and function for all registered listeners. But those operations against partition(s) do not have their events posted.

Does this PR introduce any user-facing change?

With this change, partition(s) related operations are posted into register listener as events

How was this patch tested?

Enrich UT and also tested on local cluster

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Dec 11, 2025
@waterlx
Copy link
Author

waterlx commented Dec 11, 2025

The old PR seems too stale to re-open. So a same but new PR is open here

@HyukjinKwon
Copy link
Member

Can you file a JIRA and add it to the PR title?

@waterlx waterlx changed the title Add partitions related ExternalCatalogEvent and post them in corresponding operations [SPARK-52326][SQL] Add partitions related ExternalCatalogEvent and post them in corresponding operations Dec 12, 2025
@waterlx
Copy link
Author

waterlx commented Dec 12, 2025

@HyukjinKwon The JIRA is added to PR title. Here is the JIRA link for your info: https://issues.apache.org/jira/browse/SPARK-52326, and it was filed before.

Would you please review the PR at your convenience? Thank you!

@waterlx
Copy link
Author

waterlx commented Dec 15, 2025

Rebased the code and re-run the build pipelines. All checks passed. @HyukjinKwon May I have your time to review the change? Thank you!

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in bb112e2 Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants