feat: add advanced sample for child-lifetime scope #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@tillig assigned you for this PR. If you think there is something missing please let me know. |
tillig
requested changes
Mar 2, 2020
Member
tillig
left a comment
There was a problem hiding this comment.
I think this is going to be really helpful. A little bit of standardization with filenames and some comments to help folks navigate what's going on and I think we're good.
AspNetCore3ChildlifetimeScope/Dependencies/TransientRootDependency.cs
Outdated
Show resolved
Hide resolved
e24ac8f to
c32438c
Compare
Member
Author
|
Hey @tillig, I think I've addressed everything you recommended. |
tillig
approved these changes
Mar 9, 2020
Member
tillig
left a comment
There was a problem hiding this comment.
Looks great! It'll be nice to have a working example of this for folks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ÀutofacChildLifetimescopeFactorywith two hostsCloses #16