-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(eks): eks cluster name exceeding the limit of 100 characters #34449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eks): eks cluster name exceeding the limit of 100 characters #34449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
…me-can-exceed-100-characters
|
Exemption Request: Error gets thrown before deployment so an integration test is not needed. |
GavinZZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Relates to #30632 but does not close the issue.
Reason for this change
The cluster name can exceed 100 characters, which exceeds the limit for EKS.
Description of changes
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license