Skip to content

Conversation

@astiwana
Copy link
Contributor

@astiwana astiwana commented May 13, 2025

Issue # (if applicable)

Relates to #30632 but does not close the issue.

Reason for this change

The cluster name can exceed 100 characters, which exceeds the limit for EKS.

Description of changes

  • Check if the cluster name exceeds 100 characters
  • If it does, throw a validation error

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added unit test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels May 13, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 13, 2025 18:39
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 13, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@astiwana astiwana changed the title fix(aws-eks): eks cluster name exceeding the limit of 100 characters fix(eks): eks cluster name exceeding the limit of 100 characters May 13, 2025
@astiwana
Copy link
Contributor Author

Exemption Request: Error gets thrown before deployment so an integration test is not needed.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label May 14, 2025
Copy link
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9cb7f17
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@paulhcsun paulhcsun added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels May 14, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 14, 2025 22:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented May 14, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5197882 into aws:main May 14, 2025
35 of 37 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants