Skip to content

Conversation

@paulhcsun
Copy link
Contributor

See CHANGELOG


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

iliapolo and others added 2 commits May 19, 2025 09:41
…` property fails (#34498)

The [addition](8ee4427) of the `@propertyInjectable` decorator onto `NodejsFunction` breaks it because it alters the callstack, which is inspected inside the construct to automagically determine the entrypoint of the function.

Closes #34486

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation aws-cdk-automation requested a review from a team May 19, 2025 16:57
@github-actions github-actions bot added the p2 label May 19, 2025
@paulhcsun paulhcsun added pr/no-squash This PR should be merged instead of squash-merging it pr-linter/analytics-metadata-change and removed p2 labels May 19, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 19, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ef96c95
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 19, 2025

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b88e516 into v2-release May 19, 2025
37 checks passed
@mergify mergify bot deleted the patch/v2.196.1 branch May 19, 2025 17:27
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. pr/no-squash This PR should be merged instead of squash-merging it pr-linter/analytics-metadata-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants