feat(eks-v2-alpha): make objectName optional in KubernetesObjectValue

[wafuwafu13]

Issue # (if applicable)

Closes #34148

Reason for this change

Currently, objectName is required so we can't retrieve some values from cluster without objectName like kubectl get pod -o jsonpath={.apiVersion}.

aws-cdk/packages/aws-cdk-lib/aws-eks/lib/k8s-object-value.ts

Lines 22 to 25 in 9ffa244

	/**
	* The name of the object to query.
	*/
	readonly objectName: string;

Description of changes

Describe any new or updated permissions being added

When objectName is not provided, pass the default --all-namespaces=false argument which has no effect.

Description of how you validated changes

Pass unit tests

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

[wafuwafu13]

Exemption Request

Unit tests exist

[aemada-aws]

Exemption Request

Unit tests exist

It still needs an integ test because building an invalid command would cause deployment to fail, which the integ test catches but the unit test does not.

[aemada-aws]

We shouldn't "hack" the parameter by passing a flag or an empty string in place of ObjectName, instead we should handle the case of ObjectName not being provided in the custom resource at:

aws-cdk/packages/@aws-cdk/aws-eks-v2-alpha/lib/kubectl-handler/get/__init__.py

Line 44 in e7c3b53

output = wait_for_output(['get', '-n', object_namespace, object_type, object_name, "-o=jsonpath='{{{0}}}'".format(json_path)], int(timeout_seconds))

[aemada-aws]

we should make this pr a feat not a fix because technically we are not fixing a bug but rather allowing extra functionality.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 955aac1
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository