feat: golang runtime library definition #1894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
| "description": "", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "fmt": "go fmt ./jsii", |
Contributor
There was a problem hiding this comment.
Could/should this be lint?
Contributor
Author
There was a problem hiding this comment.
fmt actually rewrites files, I'll create a separate lint task for fmt "check"
97ff125 to
9c6e72a
Compare
9f07ab4 to
bf51fd5
Compare
bf51fd5 to
1cd61f1
Compare
Scaffolding for go runtime library implementation. Defines steps for building, unit testing, and integration testing with generated jsii-calc modules.
1cd61f1 to
0bace9f
Compare
SoManyHs
approved these changes
Sep 9, 2020
| ): void { | ||
| const result = spawnSync(command, args, { | ||
| ...opts, | ||
| shell: process.platform === 'win32', |
Contributor
There was a problem hiding this comment.
Nit: might be worth constantizing this?
Contributor
Author
|
Closing in favor of #1996, branch on origin instead of form allows for easier collaboration pre-merge. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines go runtime library package and begins layout of process management and request/response flow. Begins test suite that initializes client and verifies expected response from node runtime. Adds build scripts for embedding js runtime lib and generating jsii-calc go modules for testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.