fix: remove overly strict checks on peer versions #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) ProjectInfo was verifying that the specified version range in peerDependencies is exactly the same as the version range in regular dependencies. This is not necessary, the only requirement is that the actual concrete dependency version satisfies the peer dependency version (which is already checked in _loadDependencies). 2) Assembler was verifying that the concrete version of a library found in dependencies was the same as that same concrete library found in peerDependencies. But since there's ever only one concrete copy of any dependency, this check can never fail.
eladb
approved these changes
Nov 9, 2018
dstufft
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProjectInfo was verifying that the specified version range in
peerDependencies is exactly the same as the version range in regular
dependencies. This is not necessary, the only requirement is that
the actual concrete dependency version satisfies the peer dependency
version (which is already checked in _loadDependencies).
Assembler was verifying that the concrete version of a library found
in dependencies was the same as that same concrete library found in
peerDependencies. But since there's ever only one concrete copy of
any dependency, this check can never fail.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.