Abstract proxy classes need to inherent from parent's proxies #377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the JSII, we generate a proxy class for any Abstract classes. This proxy class inherits from the abstract class, and does nothing but provide implementations of any abstract methods/properties that just call into the JSII. However, this only worked for abstract methods defined on this specific abstract class, not any parent abstract classes.
This PR resolves that issue, by building up a list of all abstract classes in an abstract class's inheritance tree, and then has the proxy depend on it.
Because the actual name of the abstract class is not part of a module's public interface, this PR adds a
jsii.proxy_forfunction, which takes an abstract class and returns the proxy class for it.Before:
After:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.