Implement Async Function Support #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstufft
commented
Mar 18, 2019
| __jsii_type__ = "Object" | ||
|
|
||
|
|
||
| def _handle_callback(kernel, callback): |
Contributor
Author
There was a problem hiding this comment.
Note, this doesn't actually handle everything, this is one of the things that we need to coordinate with the sync callbacks with over who wants to "own" doing the complete implementation of this.
Contributor
There was a problem hiding this comment.
Do you just want to merge this version and then I can do a PR with the updated version?
dstufft
commented
Mar 18, 2019
| # These map distinct reasons for failures, so we an easily find them. | ||
| xfail_async = pytest.mark.xfail(reason="Implement async methods", strict=True) | ||
| xfail_callbacks = pytest.mark.xfail(reason="Implement callback support", strict=True) | ||
| xfail_callbacks = pytest.mark.skip(reason="Implement callback support") |
Contributor
Author
There was a problem hiding this comment.
I had to switch this to a skip, because running these tests and failing on them left the process in a bad state.
eladb
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements async function support, exposing it the same as a sync function in the Python language.
This is basically done, but will need to coordinate with sync callbacks to make sure we're not doing anything drastically different for the bits that are going to be shared.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.