feat(python): Add support for synchronous callbacks #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
March 15, 2019 11:44
…but only for simple, positional arguments. Also, one test for getting a property is now failing and needs to be fixed.
…cks happening in the context of async callbacks.
…ter a Begin request.
| def test_objectIdDoesNotGetReallocatedWhenTheConstructorPassesThisOut(): | ||
| class PartiallyInitializedThisConsumerImpl(PartiallyInitializedThisConsumer): | ||
| def consume_partially_initialized_this(self): | ||
| def consume_partially_initialized_this(self, obj, dt, en): |
Contributor
There was a problem hiding this comment.
Would be nice if you can also assert that dt and en have the correct values (like the Java implementation does).
dstufft
suggested changes
Mar 28, 2019
Contributor
dstufft
left a comment
There was a problem hiding this comment.
Delete the:
xfail_callbacks = pytest.mark.skip(reason="Implement callback support")From the top of the file, since all of the xfail_callbacks should be gone now, we no longer need it around.
packages/jsii-python-runtime/src/jsii/_kernel/providers/process.py
Outdated
Show resolved
Hide resolved
packages/jsii-python-runtime/src/jsii/_kernel/providers/process.py
Outdated
Show resolved
Hide resolved
dstufft
approved these changes
Mar 28, 2019
Contributor
|
👯 |
RomainMuller
added a commit
that referenced
this pull request
Mar 28, 2019
### Bug Fixes * **kernel:** Transitively consider properties when deserializing structs ([#409](#409)) ([66789e8](66789e8)) * **python:** Lift the entire data class hierarchy ([#408](#408)) ([f813620](f813620)) ### Features * **python:** Add support for synchronous callbacks ([#407](#407)) ([4cb91b3](4cb91b3))
Merged
eladb
pushed a commit
that referenced
this pull request
Mar 28, 2019
### Bug Fixes * **kernel:** Transitively consider properties when deserializing structs ([#409](#409)) ([66789e8](66789e8)) * **python:** Lift the entire data class hierarchy ([#408](#408)) ([f813620](f813620)) ### Features * **python:** Add support for synchronous callbacks ([#407](#407)) ([4cb91b3](4cb91b3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for synchronous callbacks in Python as well as a number of other small fixes.
Fixes #405
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.