Skip to content

Conversation

@hlship
Copy link
Collaborator

@hlship hlship commented Jan 18, 2019

Yes, it's an incompatible change, but it simplifies things greatly. I've also updated some documentation to reflect Clojure 1.10.

This was also a chance to update documentation, docstrings, and some code.

@hlship hlship self-assigned this Jan 18, 2019
@hlship hlship added this to the 0.1.37 milestone Jan 19, 2019
@hlship hlship requested a review from pmoriarty January 20, 2019 04:24
@staypufd
Copy link

I was just reading about the nREPL project and it’s documentation. If you change this to put only to out then It may not be usuable with the nREPL based on what nREPL says about requirements for Pretty Printers.

https://nrepl.org/nrepl/design/middleware.html down in the section on Pretty Printing it has the requirements.

@hlship
Copy link
Collaborator Author

hlship commented Jan 28, 2019

I'm not sure how these two things relate, or at least, how the changes proposed are in any way a change from the current behavior; essentially, all the Writer code was an alternative to using with-out-str; this PR removes the writer namespace, and makes use of with-out-str.

@staypufd
Copy link

Ok - I probably just misunderstand how the nREPL pretty-printer would interface with your awesome pretty-printer.

I think that when I read that nREPL expects a custom printer to return and string and not a value I confused that with how it would interface into yours. But now I see that your returns a string and so it’s fine and having a Writer to write on doesn’t really matter to nREPL.

@hlship hlship merged commit 41c7350 into master Jan 30, 2019
@hlship hlship deleted the 20190118-simplify-output branch January 30, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants