Fix activerecord tests and empty collection handling #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"strip_invalid_utf_8_chars(xml)" didn't handle being passed "nil".
To do this: * Database testing was switched to in-memory, resulting in a substantial performance improvement. * Handling for sub-second date precision was added, as fixtures are all inserted within a second. * All activerecord tests are now wrapped in transactions.
Time#succ is obsolete since 1.9.2 for time is not a discrete value.
Contributor
Author
|
@cbeer Is there anything in particular I should do to get my pull-requests reviewed? |
Member
|
Thanks for the bump (and the patches); merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request fixes the exist
activerecord_providertests and then adds a new test (and associated functionality) to ensure empty collections are handled in a sane fashion.In the process: