[Feature] Run deepwalk examples with ogbn data #5268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:
|
Collaborator
rudongyu
suggested changes
Feb 6, 2023
Collaborator
rudongyu
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I've added some comments.
Besides, we also need to update the evaluation guide and the results related to ogbn data in readme. Do you have resources to do that?
| fast_neg=args.fast_neg, | ||
| ogbl_name=args.ogbl_name, | ||
| load_from_ogbl=args.load_from_ogbl, | ||
| ogbn_name=args.ogbn_name, |
Collaborator
There was a problem hiding this comment.
It seems the logic of loading data from ogbn is similar to that from ogbl. How about using load_from_ogb and ogb_name to unify the entrance and branching in load_from_ogb_with_name function according to the prefix of dataset name?
| "ogbl-collab", | ||
| "ogbl-ddi", | ||
| "ogbl-ppa", | ||
| "ogbl-citation", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "ogbl-citation", | |
| "ogbl-citation2", |
| elif load_from_ogbn: | ||
| assert ( | ||
| len(gpus) == 1 | ||
| ), "ogb.linkproppred is not compatible with multi-gpu training." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The deepwalk example currently only supports ogbl dataset. Actually other algorithms like line can run ogbn dataset. So to compare performance of different algorithms against ogb dataset, the deepwalk example should support ogbn dataset. See #5238.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes