Optimize Scikit-learn model loading by adding Bulk Tree Construction API #651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a bulk tree construction API that significantly improves performance when importing scikit-learn RandomForest models into Treelite. In my benchmarks, the new API achieves ~7-10x speedup over the existing node-by-node construction approach of the current sklearn loader.
The current implementation spends significant time in per-node overhead due to:
This becomes a bottleneck in workflows like cuML's
RandomForestClassifier.from_sklearn(), where treelite import time dominates the conversion process.This PR implements a
BulkConstructTreefriend function that directly populates the Tree class's internal ContiguousArray members in a single pass, bypassing theModelBuilderabstraction for sklearn imports.Initial benchmarks: