Proxy exitJS synchronously, just like the low level proc_exit #18770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Feb 16, 2023
Member
tlively
left a comment
There was a problem hiding this comment.
Won't synchronous proxying make the worker wait forever? Or is that not a problem because it will be terminated by the main thread during the exit. Does this work both with and without EXIT_RUNTIME?
Collaborator
Author
Yes, when you call exit() from a worker it will then block forever until it gets terminated. This was already true for (i.e. proc_exit was already proxied fully synchronously). |
tlively
approved these changes
Feb 16, 2023
kripken
approved these changes
Feb 16, 2023
sbc100
added a commit
that referenced
this pull request
Feb 16, 2023
Also, convert test_html5_core. These are the two tests that otherwise will fail when #18770 lands.
This simplifies the code and reduces code size. Add testing of both `exit` and `_exit` in test_pthread_exit_runtime.
sbc100
added a commit
that referenced
this pull request
Aug 16, 2023
These are the two tests otherwise starting failing with #18770. The reason is that.
sbc100
added a commit
that referenced
this pull request
Aug 18, 2023
These are the two tests otherwise starting failing with #18770. The reason is that.
sbc100
added a commit
that referenced
this pull request
Aug 21, 2023
These are the two tests otherwise starting failing with #18770. The reason is that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the code and reduces code size. Allows removal of separate
exitOnMainThread function.
Add testing of both
exitand_exitin test_pthread_exit_runtime.