Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Feb 27, 2023

This is something we already did autoconf mode.

@sbc100 sbc100 requested review from dschuff and kripken and removed request for dschuff February 27, 2023 23:28
This is something we already did autoconf mode.
@sbc100 sbc100 changed the title Make output scripts executable by default when targeting node [WIP] Make output scripts executable by default when targeting node Feb 28, 2023
@kripken
Copy link
Member

kripken commented Feb 28, 2023

Is this motivated by something specific?

Also, does it work with JS minification - wouldn't that strip the added line? (in autoconf maybe we don't optimize anyhow and it's fine, but in general I'm not sure)

@sbc100
Copy link
Collaborator Author

sbc100 commented Feb 28, 2023

Is this motivated by something specific?

Also, does it work with JS minification - wouldn't that strip the added line? (in autoconf maybe we don't optimize anyhow and it's fine, but in general I'm not sure)

I'm going to rethink this. Abandoning for now. The main motivations here are convenience (for folks like me who are lazy), and compatibility with normal toolchains (that produce executable content by default).

My alternative apprpach I think this is to continue to output a.out.js and then output a.out alongside it, where a.out is just a one line launcher for a.out.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants