Attempt to terminate workers cooperatively #19738
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d837bca to
8a92803
Compare
This change is designed fix address pthread thread flakiness around process termination. For example see #19683 and #15014. In some cases I believe that workers are being terminated while they have postMessage messages in their queue, so messages are getting lost. In other cases we are seeing message arrive after the call to `terminate()`. This change attempts to avoid using `terminate()` at all and attempts to cooperatively shut down the worker. We only use `terminate()` if the thread doesn't respond in a certain amount of time.
8a92803 to
ba07983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is designed fix address pthread thread flakiness around process termination. For example see #19683 and #15014.
In some cases I believe that workers are being terminated while they have postMessage messages in their queue, so messages are getting lost.
In other cases we are seeing message arrive after the call to
terminate().This change attempts to avoid using
terminate()at all and attempts to cooperatively shut down the worker. We only useterminate()if the thread doesn't respond in a certain amount of time.